Fix readthedocs build #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bee8827.
Fixes pybind#667 The sphinx version is pinned by readthedocs, but sphinx 1.3.5 is not available with conda python 3.6. The workaround is to pin the python version to 3.5 (it doesn't really matter for the docs build).
|
Thank you -- all agreed, let's revert #582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
The sphinx version is pinned by readthedocs, but sphinx 1.3.5 is not available with conda python 3.6. The workaround is to pin the python version to 3.5 (it doesn't really matter for the docs build).
Note: This PR also reverts #582 because it produces compiler errors on all platforms and the CI tests don't pass otherwise. If there is some other plan for that, let me know and I'll remove it from this PR.