Make array ctor template on shape and stride parameters #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldanor
reviewed
Jan 1, 2017
| template<typename T> array(const std::vector<size_t>& shape, | ||
| const std::vector<size_t>& strides, | ||
| template<typename T, typename ST, typename DT> | ||
| array(const ST& shape, |
| @@ -328,8 +328,9 @@ class array : public buffer { | |||
|
|
|||
| array() : array(0, static_cast<const double *>(nullptr)) {} | |||
|
|
|||
| array(const pybind11::dtype &dt, const std::vector<size_t> &shape, | |||
| const std::vector<size_t> &strides, const void *ptr = nullptr, | |||
| template <typename ST, typename DT> | |||
There was a problem hiding this comment.
Maybe s/ST/Shape/, s/DT/Strides/ (in other overloads too) so the signatures are a bit less cryptic?
SylvainCorlay
force-pushed
the
template-ctor
branch
3 times, most recently
from
b142c20 to
acbcdeb
Compare
SylvainCorlay
force-pushed
the
template-ctor
branch
from
acbcdeb to
8189692
Compare
|
Merged, thanks! |
|
I think this PR was WIP. All the CI tests were failing with compiler errors. |
dean0x7d
added a commit
to dean0x7d/pybind11
that referenced
this pull request
Feb 14, 2017
This reverts commit bee8827.
Merged
|
REVERTED -- I (mistakenly) assumed this was ready (it seemed like an innocuous change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to initialize arrays with other sequence types than std::vector without copying strides and shape into a vector first.