Skip to content

fix: prepare for 3.14 beta 2 #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

fix: prepare for 3.14 beta 2 #5697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_methods_and_attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,9 @@ def test_property_rvalue_policy():
# https://foss.heptapod.net/pypy/pypy/-/issues/2447
@pytest.mark.xfail("env.PYPY")
@pytest.mark.xfail(
sys.version_info == (3, 14, 0, "beta", 1),
reason="3.14.0b1 bug: https://github.com/python/cpython/issues/133912",
sys.version_info == (3, 14, 0, "beta", 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

sys.version_info in ((3, 14, 0, "beta", 1), (3, 14, 0, "beta", 2))

?
(also in tests/test_pickling.py)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could even do

sys.version_info[:4] == (3, 14, 0, "beta") and sys.version_info[4] in {1, 2}

But since this is a limited one-off (and we can remove it in a while, we don't support pre-releases forever), I wasn't too worried here, whatever reads best.

or sys.version_info == (3, 14, 0, "beta", 2),
reason="3.14.0b1/2 bug: https://github.com/python/cpython/issues/133912",
strict=True,
)
def test_dynamic_attributes():
Expand Down
2 changes: 1 addition & 1 deletion tests/test_multiple_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_independent_subinterpreters():

sys.path.append(".")

# This is supposed to be added to PyPI sometime in 3.14's lifespan
# This is supposed to be added in 3.14.0b3
if sys.version_info >= (3, 15):
import interpreters
elif sys.version_info >= (3, 13):
Expand Down
5 changes: 3 additions & 2 deletions tests/test_pickling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ def test_roundtrip(cls_name):
pytest.param(
"PickleableWithDict",
marks=pytest.mark.xfail(
sys.version_info == (3, 14, 0, "beta", 1),
reason="3.14.0b1 bug: https://github.com/python/cpython/issues/133912",
sys.version_info == (3, 14, 0, "beta", 1)
or sys.version_info == (3, 14, 0, "beta", 2),
reason="3.14.0b1/2 bug: https://github.com/python/cpython/issues/133912",
strict=True,
),
),
Expand Down
Loading