fix: prepare for 3.14 beta 2 #5697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
approved these changes
May 27, 2025
| @@ -306,8 +306,9 @@ def test_property_rvalue_policy(): | |||
| # https://foss.heptapod.net/pypy/pypy/-/issues/2447 | |||
| @pytest.mark.xfail("env.PYPY") | |||
| @pytest.mark.xfail( | |||
| sys.version_info == (3, 14, 0, "beta", 1), | |||
| reason="3.14.0b1 bug: https://github.com/python/cpython/issues/133912", | |||
| sys.version_info == (3, 14, 0, "beta", 1) | |||
There was a problem hiding this comment.
sys.version_info in ((3, 14, 0, "beta", 1), (3, 14, 0, "beta", 2))
?
(also in tests/test_pickling.py)
There was a problem hiding this comment.
Could even do
sys.version_info[:4] == (3, 14, 0, "beta") and sys.version_info[4] in {1, 2}But since this is a limited one-off (and we can remove it in a while, we don't support pre-releases forever), I wasn't too worried here, whatever reads best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
python/cpython#133912 isn't blocking the 3.14b2 release (already tagged), so we have to extend our test skip.
The fix is in python/cpython#134725 (haven't tested it yet, but the added test looks correct).