Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Documentation, Variable names #839

Merged
merged 5 commits into from
Apr 30, 2022
Merged

STY: Documentation, Variable names #839

merged 5 commits into from
Apr 30, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #839 (3d9bd5a) into main (3fe9e6e) will increase coverage by 0.31%.
The diff coverage is 82.41%.

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   81.79%   82.11%   +0.31%     
==========================================
  Files          16       16              
  Lines        3703     3768      +65     
  Branches      803      805       +2     
==========================================
+ Hits         3029     3094      +65     
  Misses        499      499              
  Partials      175      175              
Impacted Files Coverage Δ
PyPDF2/generic.py 85.37% <ø> (ø)
PyPDF2/merger.py 67.33% <42.55%> (-0.85%) ⬇️
PyPDF2/_page.py 79.12% <66.66%> (ø)
PyPDF2/_reader.py 81.29% <93.10%> (+0.12%) ⬆️
PyPDF2/filters.py 74.01% <95.00%> (ø)
PyPDF2/_writer.py 88.74% <100.00%> (+0.02%) ⬆️
PyPDF2/constants.py 100.00% <100.00%> (ø)
PyPDF2/xmp.py 50.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe9e6e...3d9bd5a. Read the comment docs.

@MartinThoma MartinThoma merged commit 444fca2 into main Apr 30, 2022
@MartinThoma MartinThoma deleted the style-improvements branch April 30, 2022 18:19
MartinThoma added a commit that referenced this pull request May 1, 2022
Robustness (ROB):
-  Handle missing destinations in reader (#840)
-  warn-only in readStringFromStream (#837)
-  Fix corruption in startxref or xref table (#788 and #830)

Documentation (DOC):
-  Project Governance (#799)
-  History of PyPDF2
-  PDF feature/version support (#816)
-  More details on text parsing issues (#815)

Developer Experience (DEV):
-  Add benchmark command to Makefile
-  Ignore IronPython parts for code coverage (#826)

Maintenance (MAINT):
-  Split pdf module (#836)
-  Separated CCITTFax param parsing/decoding (#841)
-  Update requirements files

Testing (TST):
-  Use external repository for larger/more PDFs for testing (#820)
-  Swap incorrect test names (#838)
-  Add test for PdfFileReader and page properties (#835)
-  Add tests for PyPDF2.generic (#831)
-  Add tests for utils, form fields, PageRange (#827)
-  Add test for ASCII85Decode (#825)
-  Add test for FlateDecode (#823)
-  Add test for filters.ASCIIHexDecode (#822)

Code Style (STY):
-  Apply pre-commit (black, isort) + use snake_case variables (#832)
-  Remove debug code (#828)
-  Documentation, Variable names (#839)

Full Changelog: 1.27.9...1.27.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant