TST: Use external repository for larger/more PDFs for testing #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If going this route, I think it'd be far better to use git submodules so that the link between the repos is more explicit, though I hate submodules and would advocate for just including the PDFs into the repo as they're probably a generate once type situation. |
|
I want to avoid the repository from becoming too big. I have a couple of pdf files which are several megabytes. This would make cloning painful |
|
Submodules might be a good idea though. Most people would not need to clone the submodule 🤔 |
Codecov Report
@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 12 12
Lines 3565 3565
Branches 823 823
=======================================
Hits 2710 2710
Misses 638 638
Partials 217 217 Continue to review full report at Codecov.
|
MasterOdin
reviewed
Apr 26, 2022
MartinThoma
added a commit
that referenced
this pull request
Apr 28, 2022
* Use submodule so that the connection is clear. Ensure that Flake8 issues of the submodule don't show up here * As a first step, just try to get the number of pages from the non-encrypted PDFs * Create an "external" pytest marker which allows people to deactivate tests that need the submodule
VictorCarlquist
pushed a commit
to VictorCarlquist/PyPDF2
that referenced
this pull request
Apr 29, 2022
…#820) * Use submodule so that the connection is clear. Ensure that Flake8 issues of the submodule don't show up here * As a first step, just try to get the number of pages from the non-encrypted PDFs * Create an "external" pytest marker which allows people to deactivate tests that need the submodule
MartinThoma
added a commit
that referenced
this pull request
May 1, 2022
Robustness (ROB): - Handle missing destinations in reader (#840) - warn-only in readStringFromStream (#837) - Fix corruption in startxref or xref table (#788 and #830) Documentation (DOC): - Project Governance (#799) - History of PyPDF2 - PDF feature/version support (#816) - More details on text parsing issues (#815) Developer Experience (DEV): - Add benchmark command to Makefile - Ignore IronPython parts for code coverage (#826) Maintenance (MAINT): - Split pdf module (#836) - Separated CCITTFax param parsing/decoding (#841) - Update requirements files Testing (TST): - Use external repository for larger/more PDFs for testing (#820) - Swap incorrect test names (#838) - Add test for PdfFileReader and page properties (#835) - Add tests for PyPDF2.generic (#831) - Add tests for utils, form fields, PageRange (#827) - Add test for ASCII85Decode (#825) - Add test for FlateDecode (#823) - Add test for filters.ASCIIHexDecode (#822) Code Style (STY): - Apply pre-commit (black, isort) + use snake_case variables (#832) - Remove debug code (#828) - Documentation, Variable names (#839) Full Changelog: 1.27.9...1.27.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.