Added an example for using plotly with fpdf2#714
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 26 26
Lines 7008 7008
Branches 1258 1258
=======================================
Hits 6570 6570
Misses 260 260
Partials 178 178 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Welcome @msalem99, and thank you for your contribution! 😊
Good job overall, the example and documentation you provided are great! 👍
I tested your code, and while the 2nd script works well,
the 1st script hangs for several minutes on my computer, without ever completing.
I think it's stuck when calling the kaleido binary program.
How long does it take to execute on your machine?
I am using WSL2 (Ubuntu 20.04) under Windows, with Python 3.8.
What is your environment please?
|
The second script seems to also require the installation of kaleido as plotly uses it when writing the svg figure. I tried running the second script without kaleido and it raised an error so I am not sure why kaleido would hang in the first script on your machine but run on the second script fine. |
|
I think I may be facing this bug: plotly/Kaleido#149 I'm going to ask for some help 😊 |
|
@ msalem99: also, could you add a line about this new documentation section in |
Both worked OK on my setup - python 3.10 running on Windows 10. |
…eeded import in the example
Done, I also removed an import that was not used in the second example that I had missed before. Thank you for the feedback. |
|
Thank you @andersonhc & @manager! |
|
@allcontributors please add @msalem99 for documentation |
|
I've put up a pull request to add @msalem99! 🎉 |
Closes #653
Checklist:
The GitHub pipeline is OK (green), meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.[N/A] A unit test is covering the code added / modified by this PR
This PR is ready to be merged
[N/A] In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.