Skip to content

Adds faiman_rad and ross models to get_cell_temperature(). #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramaroesilva wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −4
Open

Adds faiman_rad and ross models to get_cell_temperature(). #2631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4143e2a
Adds faiman_rad and ross models to get_cell_temperature().
ramaroesilva Dec 18, 2025
70bb948
Addresses flake8 formatting issues.
ramaroesilva Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions pvlib/pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,11 +1217,12 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
Ambient dry bulb temperature [C]

wind_speed : numeric
Wind speed [m/s]
Wind speed [m/s], although can be ``None`` for ``'ross'`` model

model : str
Supported models include ``'sapm'``, ``'pvsyst'``,
``'faiman'``, ``'fuentes'``, and ``'noct_sam'``
``'faiman'``, ``'faiman_rad'``, ``'fuentes'``, ``'noct_sam'``,
and ``'ross'``

effective_irradiance : numeric, optional
The irradiance that is converted to photocurrent in W/m^2.
Expand Down Expand Up @@ -1267,6 +1268,12 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
required = tuple()
optional = _build_kwargs(['u0', 'u1'],
self.temperature_model_parameters)
elif model == 'faiman_rad':
func = temperature.faiman_rad
required = ()
optional = _build_kwargs(['ir_down', 'u0', 'u1',
'sky_view', 'emissivity'],
self.temperature_model_parameters)
elif model == 'fuentes':
func = temperature.fuentes
required = _build_tcell_args(['noct_installed'])
Expand All @@ -1283,11 +1290,21 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
optional = _build_kwargs(['transmittance_absorptance',
'array_height', 'mount_standoff'],
self.temperature_model_parameters)
elif model == 'ross':
func = temperature.ross
required = ()
# either noct or k must be defined
optional = _build_kwargs(['noct', 'k'],
self.temperature_model_parameters)
else:
raise ValueError(f'{model} is not a valid cell temperature model')

temperature_cell = func(poa_global, temp_air, wind_speed,
*required, **optional)
if model == 'ross':
Copy link
Contributor Author

@ramaroesilva ramaroesilva Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although wind speed was kept as an input requested by get_cell_temperature, here such a differentiation is needed since ross is apparently the only model not using wind.

temperature_cell = func(poa_global, temp_air,
*required, **optional)
else:
temperature_cell = func(poa_global, temp_air, wind_speed,
*required, **optional)
return temperature_cell

def dc_ohms_from_percent(self):
Expand Down