Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update high_availability_settings for 24.7 #149

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Update high_availability_settings for 24.7 #149

merged 5 commits into from
Aug 15, 2024

Conversation

LuminatiHD
Copy link
Contributor

@LuminatiHD LuminatiHD commented Aug 12, 2024 •
edited
Loading

Closes #148

@LuminatiHD LuminatiHD marked this pull request as ready for review August 12, 2024 10:44
@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings_v24.7 branch from ace0b80 to 5f62f03 Compare August 12, 2024 11:48
KiLLuuuhh
KiLLuuuhh requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@KiLLuuuhh KiLLuuuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes but overall very sophisticated update!

plugins/modules/system_high_availability_settings.py Show resolved Hide resolved
plugins/modules/system_high_availability_settings.py Outdated Show resolved Hide resolved
plugins/modules/system_high_availability_settings.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Show resolved Hide resolved
@kdhlab kdhlab mentioned this pull request Aug 14, 2024
Merged
KiLLuuuhh
KiLLuuuhh approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@KiLLuuuhh KiLLuuuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work! 👍

@LuminatiHD LuminatiHD merged commit d64d7a6 into puzzle:main Aug 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiLLuuuhh KiLLuuuhh KiLLuuuhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Setting Sync compatibility
2 participants
@LuminatiHD @KiLLuuuhh