Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 24.7 Support #146

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add 24.7 Support #146

merged 2 commits into from
Aug 16, 2024

Conversation

kdhlab
Copy link
Contributor

@kdhlab kdhlab commented Aug 6, 2024

I think this should be all that is required to make 24.7 work. I couldn't get the molecule tests to run locally so if someone can test, that would be good.

@DonGiovanni83
Copy link
Contributor

Thank you very much for you contribution, it is much appreciated. I will test your changes in the coming days and follow up with any feedback.

@KiLLuuuhh
Copy link
Contributor

Hi @kdhlab
FYI: The molecule tests ran successfully with these changes. We'll discuss further tests for the new version later today.

@KiLLuuuhh
Copy link
Contributor

I wrote a little checklist for each module in order to keep track of any eventual changes required:

module xml-comparison release notes molecule tests unit tests mvc app models no additional config required
firewall_rules
interfaces_assignments
system_access_users none found
system_high_availability_settings changes detected no changes mentioned changes detected #148
system_settings_general none found
system_settings_logging none found

With this checks made, this pull request is currently blocked by #148.

@kdhlab
Copy link
Contributor Author

kdhlab commented Aug 14, 2024

Closing this in favor of #149

@kdhlab kdhlab closed this Aug 14, 2024
@KiLLuuuhh KiLLuuuhh reopened this Aug 15, 2024
@KiLLuuuhh
Copy link
Contributor

Dear @kdhlab

Could you please rebase with d64d7a6? Your pull-request includes all other important changes needed to add compatibility with 24.7.

Again, thank you for your vital contribution!

@kdhlab
Copy link
Contributor Author

kdhlab commented Aug 15, 2024

@KiLLuuuhh rebased. Let me know if we need anything else.

Copy link
Contributor

@rekup rekup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiLLuuuhh KiLLuuuhh merged commit d40cade into puzzle:main Aug 16, 2024
30 checks passed
@kdhlab kdhlab deleted the 24.7 branch September 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants