Skip to content

Reset backoff to 0 on success (was never reset), and reset connection… #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

rh78
Copy link

@rh78 rh78 commented Jan 8, 2020

… and disconnection tasks upon error to make reconnect logic work

@rh78
Copy link
Author

rh78 commented Jan 8, 2020

This PR fixes several issues:

  1. the backoff timeout was only growing, was never reset
  2. When a disconnect occured, only once a reconnect was tried, and then no reconnect attempt happened anymore, because the connection task was not set to NULL
  3. The HTTP authorizer makes not much sense without any authorization means to the application server - it now supports a bearer token

@rh78
Copy link
Author

rh78 commented Jan 8, 2020

(suggestion: it would maybe make sense to fix the HTTP authorizer in a more flexible way - e.g. like in the Java client, were the implementor could just set any headers on the request as required)

@damdo
Copy link
Contributor

damdo commented Jan 30, 2020

Hey Reinhard @rh78 thank you for your contribution, this is great!
We are taking a slightly different approach with the reconnection fix (here: #95) but your suggestion has been really valuable. The backoff fix is 👌 and it would be nice to get it merged soon! As for the bear HTTP Auth authorization means we could discuss it on a dedicated PR.

So what we could do is, keep this PR for the backoff fix, and open a new one for the HTTP authorization. How do you feel about it?

@stale
Copy link

stale bot commented Mar 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

@stale stale bot added the wontfix label Mar 31, 2021
@rh78
Copy link
Author

rh78 commented Mar 31, 2021

Could you please check if this issue is still an issue? Maybe we can close it.

@stale stale bot removed the wontfix label Mar 31, 2021
@elverkilde
Copy link
Contributor

This was incorporated in #112 and released as version 2.1.0

@elverkilde elverkilde closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants