Skip to content

Implement Targets #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 32 commits into from
Closed

Implement Targets #811

wants to merge 32 commits into from

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #681

Currently a WIP and I'll be gone for a week after submitting this.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@JordanMartinez
Change template spago.dhall to multi-target format
555cd27
@JordanMartinez
Define types: Target and TargetName
f89ee67
@JordanMartinez
Define common target names
50c6037
@JordanMartinez
Make Config have targets, update Dhall parsing
f1e6147
@JordanMartinez
Add targetName arg to CLI commands
07c2db9
@JordanMartinez
Define HasTarget alias
aa58bee
@JordanMartinez
Update spago repl to support targets
08463cb
@JordanMartinez
Update spago sources to use targets
531d6d6
@JordanMartinez
Updat sources to support targets
54a377d
@JordanMartinez
Update spago ls to support targets
c04b21b
@JordanMartinez
Refactor process for getting target
8790f52
@JordanMartinez
Refactor LsEnv to InstallEnv2
c83e213
@JordanMartinez
Update install to support targets
a2d2557
@JordanMartinez
Support targets for build, run, test, bundle-*
f869dd5
@JordanMartinez
Support targets for search
4c829ca
@JordanMartinez
Support targets for docs
ff1f12e
@JordanMartinez
Drop '2' suffix on replacement Env; drop old Env
4a60828
@JordanMartinez
Reduce diff: swap order of args
09ae7d1
@JordanMartinez
Remove unneeded whitespace
d33989a
@JordanMartinez
Implement addRawDeps for targets
cb896ec
@JordanMartinez
Migrate psc-package: use target-based add deps
6226017
@JordanMartinez
Migrate bower: add target deps
fc98b77
@JordanMartinez
Use one traversal to handle let bindings
e07400b
@JordanMartinez
Make install handle more Dhall expressions
d81287d
@JordanMartinez
Migrate v1 and v2 configs to v3 Dhall expr
d8245fb
@JordanMartinez
Normalize dhall expression before parsing
72c4711
@JordanMartinez
Make bumpVersion require a target
834d034
@JordanMartinez
Make bumpVersion use target's dependencies
efd44fd
@JordanMartinez
Remove configSourcePaths from Config
5105bd9
@JordanMartinez
Remove dependencies from Config type
cd108f2
@JordanMartinez JordanMartinez marked this pull request as ready for review August 24, 2021 14:44
@f-f f-f mentioned this pull request Aug 25, 2021
Closed
@JordanMartinez
Copy link
Contributor Author

I've updated this PR to add dependencies to the first ListLit it finds. If it doesn't find any (e.g. target1.dependencies # target2.dependencies), then it'll add one to the right end.

This was referenced Aug 28, 2021
Closed
Closed
@thomashoneyman thomashoneyman mentioned this pull request Sep 2, 2021
Open
@JordanMartinez
Copy link
Contributor Author

This PR should be refactored to build off of #815.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: remove need for multiple spago.dhall config files by defining output targets in spago.dhall
1 participant
@JordanMartinez