Skip to content

Add unionWith #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2020
Merged

Add unionWith #21

merged 4 commits into from
Dec 28, 2020

Conversation

Zelenya
Copy link
Contributor

@Zelenya Zelenya commented Dec 23, 2020

It's seems like it could be useful. Right now I use a couple of newtypes with different semigroup instances for this

kl0tl
kl0tl reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow us to implement the Semigroup instance with append = unionWith (<>) but this is breaking (see #19).

kl0tl
kl0tl approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kl0tl
Copy link
Member

kl0tl commented Dec 28, 2020

We merged #19 so we could implement the Semigroup instance with append = unionWith (<>) in this pull request.

Tests should pass with a rebase once #22 is merged.

@JordanMartinez JordanMartinez merged commit 6427ae9 into purescript:master Dec 28, 2020
@kl0tl kl0tl mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

@kl0tl kl0tl kl0tl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zelenya @kl0tl @hdgarrood @JordanMartinez