Fix the Semigroup instance for Foreign.Object.Object #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Semigroup instance for Foreign.Object.Object currently appends values from the right to values from the left: `singleton k a <> singleton k b` is equivalent to `singleton k (b <> a)` and not to `singleton k (a <> b)` as expected.
This was referenced Dec 19, 2020
|
It's unfortunate that this is breaking but I agree that it's hard to argue in favour of the current behaviour. I think if people were intentionally using it, they probably would have opened an issue asking whether this was really meant to work this way. |
hdgarrood
approved these changes
Dec 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Semigroup instance for Foreign.Object.Object currently appends values from the right to values from the left:
singleton k a <> singleton k bis equivalent tosingleton k (b <> a)and not tosingleton k (a <> b)as expected.