Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Refactor #44

Merged
merged 10 commits into from
Aug 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,36 +21,36 @@ bower install git@github.com:lumihq/purescript-react-basic.git
Here is an example component which renders a label read from props along with a counter:

```purescript
module React.Basic.Example where
module Counter where

import Prelude

import React.Basic (ReactComponent, react)
import React.Basic as React
import React.Basic.DOM as R
import React.Basic.Events as Events

-- The props for the component
type ExampleProps =
type Props =
{ label :: String
}

-- Create a component by passing a record to the `react` function.
-- The `render` function takes the props and current state, as well as a
-- state update callback, and produces a document.
component :: ReactComponent ExampleProps
component = react { displayName: "Counter", initialState, receiveProps, render }
component :: React.Component Props
component = React.component { displayName: "Counter", initialState, receiveProps, render }
where
initialState =
{ counter: 0
}

receiveProps _ _ _ =
receiveProps _ =
pure unit

render props state setState =
render { props, state, setState } =
R.button
{ onClick: Events.handler_ do
setState \s -> s { counter = s.counter + 1 }
setState \s -> s { counter = s.counter + 1 }
, children: [ R.text (props.label <> ": " <> show state.counter) ]
}
```
Expand Down
8 changes: 7 additions & 1 deletion bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
"purescript-nullable": "^4.0.0",
"purescript-typelevel-prelude": "^3.0.0",
"purescript-record": "^1.0.0",
"purescript-effect": "^2.0.0"
"purescript-effect": "^2.0.0",
"purescript-web-events": "^1.0.0",
"purescript-web-dom": "^1.0.0",
"purescript-exceptions": "^4.0.0"
},
"devDependencies": {
"purescript-web-html": "^1.0.0"
}
}
25 changes: 22 additions & 3 deletions codegen/index.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,27 @@
const fs = require('fs');
const { props, voids, types, reserved } = require('./consts');
const genFile = "../src/React/Basic/DOM/Generated.purs";

const header = `-- | ----------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------

module React.Basic.DOM.Generated where

import Prim.Row (class Union)
import React.Basic (JSX, element)
import React.Basic.DOM.Internal (SharedProps, unsafeCreateDOMComponent)
import React.Basic.Events (EventHandler)

`;

const printRecord = (elProps) => elProps.length ? `
( ${ elProps.map((p) =>
`${p} :: ${types[p] || "String"}`).join("\n , ")
}
)` : "()"

props.elements.html
const domTypes = props.elements.html
.map((e) => {
const noChildren = voids.includes(e);
const symbol = reserved.includes(e) ? `${e}'` : e;
Expand All @@ -20,11 +35,15 @@ props.elements.html
. Union attrs attrs_ (SharedProps Props_${e})
=> Record attrs
-> JSX
${symbol} = createElement (unsafeCreateDOMComponent "${e}")${
${symbol} = element (unsafeCreateDOMComponent "${e}")${
noChildren ? "" : `

${e}_ :: Array JSX -> JSX
${e}_ children = ${symbol} { children }`
}
`;
}).forEach((x) => console.log(x.replace(/^\n\ {4}/, "").replace(/\n\ {4}/g, "\n")))
}).map((x) => x.replace(/^\n\ {4}/, "").replace(/\n\ {4}/g, "\n")).join("\n");

console.log(`Writing "${genFile}" ...`);
fs.writeFileSync(genFile, header + domTypes);
console.log("Done.");
7 changes: 4 additions & 3 deletions examples/component/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
all: node_modules
purs compile src/*.purs '../../src/**/*.purs' '../../bower_components/purescript-*/src/**/*.purs'
purs bundle --module Container output/*/*.js > output/bundle.js
echo 'module.exports = PS.Container;' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js index.js -o html/index.js
purs bundle output/*/*.js > output/bundle.js
echo 'PS.Main.main();' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js -o html/index.js

node_modules:
npm install

10 changes: 0 additions & 10 deletions examples/component/index.js

This file was deleted.

11 changes: 3 additions & 8 deletions examples/component/package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
{
"name": "component",
"version": "1.0.0",
"description": "",
"keywords": [],
"author": "",
"dependencies": {
"react": "^16.2.0",
"react-dom": "^16.2.0"
"react": "^16.4.2",
"react-dom": "^16.4.2"
},
"devDependencies": {
"browserify": "^16.1.0"
"browserify": "^16.2.2"
}
}
10 changes: 5 additions & 5 deletions examples/component/src/Container.purs
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
module Container where

import React.Basic (ReactComponent, createElement, stateless)
import React.Basic as React
import React.Basic.DOM as R
import ToggleButton as ToggleButton

component :: ReactComponent {}
component = stateless { displayName: "Container", render }
component :: React.Component {}
component = React.stateless { displayName: "Container", render }
where
render _ =
R.div
{ children:
[ createElement ToggleButton.component { on: true }
, createElement ToggleButton.component { on: false }
[ React.element ToggleButton.component { on: true }
, React.element ToggleButton.component { on: false }
]
}
23 changes: 23 additions & 0 deletions examples/component/src/Main.purs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
module Main where

import Prelude

import Container as Container
import Data.Maybe (Maybe(..))
import Effect (Effect)
import Effect.Exception (throw)
import React.Basic (element)
import React.Basic.DOM (render)
import Web.DOM.NonElementParentNode (getElementById)
import Web.HTML (window)
import Web.HTML.HTMLDocument (toNonElementParentNode)
import Web.HTML.Window (document)

main :: Effect Unit
main = do
container <- getElementById "container" =<< (map toNonElementParentNode $ document =<< window)
case container of
Nothing -> throw "Container element not found."
Just c ->
let app = element Container.component {}
in render app c
12 changes: 6 additions & 6 deletions examples/component/src/ToggleButton.purs
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@ module ToggleButton where

import Prelude

import React.Basic (ReactComponent, react)
import React.Basic as React
import React.Basic.DOM as R
import React.Basic.Events as Events

type ExampleProps =
type Props =
{ on :: Boolean
}

component :: ReactComponent ExampleProps
component = react { displayName: "ToggleButton", initialState, receiveProps, render }
component :: React.Component Props
component = React.component { displayName: "ToggleButton", initialState, receiveProps, render }
where
initialState =
{ on: false }

receiveProps props _ setState =
receiveProps { props, setState } =
setState _ { on = props.on }

render _ state setState =
render { state, setState } =
R.button
{ onClick: Events.handler_ (setState \s -> s { on = not s.on })
, children: [ R.text if state.on then "On" else "Off" ]
Expand Down
7 changes: 4 additions & 3 deletions examples/controlled-input/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
all: node_modules
purs compile src/*.purs '../../src/**/*.purs' '../../bower_components/purescript-*/src/**/*.purs'
purs bundle --module ControlledInput output/*/*.js > output/bundle.js
echo 'module.exports = PS.ControlledInput;' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js index.js -o html/index.js
purs bundle output/*/*.js > output/bundle.js
echo 'PS.Main.main();' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js -o html/index.js

node_modules:
npm install

10 changes: 0 additions & 10 deletions examples/controlled-input/index.js

This file was deleted.

12 changes: 3 additions & 9 deletions examples/controlled-input/package.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
{
"name": "counter",
"version": "1.0.0",
"description": "",
"keywords": [],
"author": "",
"dependencies": {
"create-react-class": "^15.6.2",
"react": "^16.2.0",
"react-dom": "^16.2.0"
"react": "^16.4.2",
"react-dom": "^16.4.2"
},
"devDependencies": {
"browserify": "^16.1.0"
"browserify": "^16.2.2"
}
}
14 changes: 7 additions & 7 deletions examples/controlled-input/src/ControlledInput.purs
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@ module ControlledInput where
import Prelude

import Data.Maybe (Maybe(..), fromMaybe, maybe)
import React.Basic (ReactComponent, fragment, react)
import React.Basic as React
import React.Basic.DOM as R
import React.Basic.DOM.Events (preventDefault, targetValue, timeStamp)
import React.Basic.Events as Events

component :: ReactComponent {}
component = react { displayName: "ControlledInput", initialState, receiveProps, render }
component :: React.Component {}
component = React.component { displayName: "ControlledInput", initialState, receiveProps, render }
where
initialState =
{ value: "hello world"
, timeStamp: Nothing
}

receiveProps _ _ _ =
receiveProps _ =
pure unit
render _ state setState =
fragment

render { state, setState } =
React.fragment
[ R.input
{ onChange:
Events.handler
Expand Down
23 changes: 23 additions & 0 deletions examples/controlled-input/src/Main.purs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
module Main where

import Prelude

import ControlledInput as ControlledInput
import Data.Maybe (Maybe(..))
import Effect (Effect)
import Effect.Exception (throw)
import React.Basic (element)
import React.Basic.DOM (render)
import Web.DOM.NonElementParentNode (getElementById)
import Web.HTML (window)
import Web.HTML.HTMLDocument (toNonElementParentNode)
import Web.HTML.Window (document)

main :: Effect Unit
main = do
container <- getElementById "container" =<< (map toNonElementParentNode $ document =<< window)
case container of
Nothing -> throw "Container element not found."
Just c ->
let app = element ControlledInput.component {}
in render app c
6 changes: 3 additions & 3 deletions examples/counter/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
all: node_modules
purs compile src/*.purs '../../src/**/*.purs' '../../bower_components/purescript-*/src/**/*.purs'
purs bundle --module Counter output/*/*.js > output/bundle.js
echo 'module.exports = PS.Counter;' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js index.js -o html/index.js
purs bundle output/*/*.js > output/bundle.js
echo 'PS.Main.main();' >> output/bundle.js
node_modules/.bin/browserify output/bundle.js -o html/index.js

node_modules:
npm install
Expand Down
10 changes: 0 additions & 10 deletions examples/counter/index.js

This file was deleted.

12 changes: 3 additions & 9 deletions examples/counter/package.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
{
"name": "counter",
"version": "1.0.0",
"description": "",
"keywords": [],
"author": "",
"dependencies": {
"create-react-class": "^15.6.2",
"react": "^16.2.0",
"react-dom": "^16.2.0"
"react": "^16.4.2",
"react-dom": "^16.4.2"
},
"devDependencies": {
"browserify": "^16.1.0"
"browserify": "^16.2.2"
}
}
Loading