API Refactor #44
API Refactor #44
Conversation
src/React/Basic.purs
Outdated
| @@ -8,13 +8,15 @@ module React.Basic | |||
| , fragmentKeyed | |||
| , JSX | |||
| , ReactComponent | |||
| , ReactComponentInstance | |||
| , react | |||
There was a problem hiding this comment.
I'm thinking about the import story here. The ideal for me would be if qualified imports were assumed, so the code could be written as:
module MyComponent (component, State, Props) where
import React.Basic as React
type State = {}
type Props = {}
component :: React.Component Props
component = React.component {..}I find the current naming a bit inconsistent (some names are prefixed with React and some aren't). What do you think?
There was a problem hiding this comment.
That seems fine to me, we use that a bit as well. Pretty sure this already needs to be a major version bump anyway.
There was a problem hiding this comment.
I guess it could also be added with a backward compatible synonym (type ReactComponent = Component), same as react -> component.
| , receiveProps :: { | props } -> { | state } -> (SetState state fx) -> Effect Unit | ||
| , render :: { | props } -> { | state } -> (SetState state fx) -> JSX | ||
| , receiveProps :: | ||
| { isFirstMount :: Boolean |
There was a problem hiding this comment.
Might be worth pulling out a type synonym here?
There was a problem hiding this comment.
Yeah.. I couldn't decide. It's only repeated once and it seemed harder to read that way, plus naming the alias
src/React/Basic.purs
Outdated
| @@ -124,3 +171,21 @@ foreign import createElement_ :: forall props. Fn2 (ReactComponent { | props }) | |||
| foreign import createElementKeyed_ :: forall props. Fn2 (ReactComponent { | props }) { key :: String | props } JSX | |||
|
|
|||
| foreign import fragmentKeyed_ :: Fn2 String (Array JSX) JSX | |||
|
|
|||
| -- | Deprecated -- prefer `component` | |||
There was a problem hiding this comment.
It might be better to just remove it, if updating requires changes anyway
|
I've merged
|
src/React/Basic/DOM.purs
Outdated
| import Effect.Exception (Error, throw, try) | ||
| import Effect.Uncurried (EffectFn1, runEffectFn1) | ||
| import React.Basic (ComponentInstance, JSX) | ||
| import React.Basic.DOM.Generated (Props_a, Props_abbr, Props_address, Props_area, Props_article, Props_aside, Props_audio, Props_b, Props_base, Props_bdi, Props_bdo, Props_blockquote, Props_body, Props_br, Props_button, Props_canvas, Props_caption, Props_cite, Props_code, Props_col, Props_colgroup, Props_data, Props_datalist, Props_dd, Props_del, Props_details, Props_dfn, Props_dialog, Props_div, Props_dl, Props_dt, Props_em, Props_embed, Props_fieldset, Props_figcaption, Props_figure, Props_footer, Props_form, Props_h1, Props_h2, Props_h3, Props_h4, Props_h5, Props_h6, Props_head, Props_header, Props_hgroup, Props_hr, Props_html, Props_i, Props_iframe, Props_img, Props_input, Props_ins, Props_kbd, Props_keygen, Props_label, Props_legend, Props_li, Props_link, Props_main, Props_map, Props_mark, Props_math, Props_menu, Props_menuitem, Props_meta, Props_meter, Props_nav, Props_noscript, Props_object, Props_ol, Props_optgroup, Props_option, Props_output, Props_p, Props_param, Props_picture, Props_pre, Props_progress, Props_q, Props_rb, Props_rp, Props_rt, Props_rtc, Props_ruby, Props_s, Props_samp, Props_script, Props_section, Props_select, Props_slot, Props_small, Props_source, Props_span, Props_strong, Props_style, Props_sub, Props_summary, Props_sup, Props_svg, Props_table, Props_tbody, Props_td, Props_template, Props_textarea, Props_tfoot, Props_th, Props_thead, Props_time, Props_title, Props_tr, Props_track, Props_u, Props_ul, Props_var, Props_video, Props_wbr, a, a_, abbr, abbr_, address, address_, area, article, article_, aside, aside_, audio, audio_, b, b_, base, bdi, bdi_, bdo, bdo_, blockquote, blockquote_, body, body_, br, button, button_, canvas, canvas_, caption, caption_, cite, cite_, code, code_, col, colgroup, colgroup_, data', data_, datalist, datalist_, dd, dd_, del, del_, details, details_, dfn, dfn_, dialog, dialog_, div, div_, dl, dl_, dt, dt_, em, em_, embed, fieldset, fieldset_, figcaption, figcaption_, figure, figure_, footer, footer_, form, form_, h1, h1_, h2, h2_, h3, h3_, h4, h4_, h5, h5_, h6, h6_, head, head_, header, header_, hgroup, hgroup_, hr, html, html_, i, i_, iframe, iframe_, img, input, ins, ins_, kbd, kbd_, keygen, keygen_, label, label_, legend, legend_, li, li_, link, main, main_, map, map_, mark, mark_, math, math_, menu, menu_, menuitem, menuitem_, meta, meter, meter_, nav, nav_, noscript, noscript_, object, object_, ol, ol_, optgroup, optgroup_, option, option_, output, output_, p, p_, param, picture, picture_, pre, pre_, progress, progress_, q, q_, rb, rb_, rp, rp_, rt, rt_, rtc, rtc_, ruby, ruby_, s, s_, samp, samp_, script, script_, section, section_, select, select_, slot, slot_, small, small_, source, span, span_, strong, strong_, style, style_, sub, sub_, summary, summary_, sup, sup_, svg, svg_, table, table_, tbody, tbody_, td, td_, template, template_, textarea, textarea_, tfoot, tfoot_, th, th_, thead, thead_, time, time_, title, title_, tr, tr_, track, u, u_, ul, ul_, var, var_, video, video_, wbr) as Generated |
There was a problem hiding this comment.
If it's qualified anyway, why the explicit import list?
There was a problem hiding this comment.
The compiler emits a big warning about it when it's implicit. Is there another way around that?
| findDOMNode instance_ = try do | ||
| node <- runEffectFn1 findDOMNode_ instance_ | ||
| case toMaybe node of | ||
| Nothing -> throw "Node not found." |
There was a problem hiding this comment.
Since you're wrapping this in try anyway, you could use note here.
There was a problem hiding this comment.
I think it would need note' and probably more code, unless there's a trick for composing them I'm not seeing
No description provided.