Skip to content

Drop Ubuntu 10.04 compatibility code #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Feb 22, 2021

This is long End of Life and should not be supported.

This is long End of Life and should not be supported.
@ekohl ekohl requested a review from a team as a code owner February 22, 2021 09:59
@puppet-community-rangefinder
Copy link

apache::mod::ssl is a class

Breaking changes to this file WILL impact these 33 modules (exact match):
Breaking changes to this file MAY impact these 13 modules (near match):

apache::params is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 175 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ekohl
Copy link
Collaborator Author

ekohl commented Feb 24, 2021

Last time I checked with legal I was not allowed to sign the Puppet CLA, which is why I never contributed anything to puppet.git. If this will be enforced in modules as well I'll have to stop contributing.

@daianamezdrea
Copy link
Contributor

Hi @ekohl, thank you for your contribution! I'll check now with the team and our manager @nheaney18 how we can approach the situation and what we can do.

@david22swan david22swan merged commit 72a6705 into puppetlabs:main Mar 15, 2021
@david22swan
Copy link
Member

@ekohl
Thank's for your work, have gone ahead and merged it.
Hope to see a lot more from you in the future.

@ekohl ekohl deleted the drop-ubuntu-10.04 branch March 15, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants