(PUP-11993) Style Cops (N-P) #9263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
from
c170b92 to
8a91302
Compare
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
2 times, most recently
from
09502ce to
5a7c7e6
Compare
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
from
ef5fa24 to
4553043
Compare
This commit enables the Style/NegatedIf cop and fixes 152 autocorrectable offenses.
This commit enables Style/NegatedWhile cop and fixes 6 auto-correctable offenses.
This commit enables the Style/NestedModifier cop. No offenses were found.
This commit enables Style/NestedParenthesizedCalls cop and fixes 3 autocorrectable offenses.
This commit enables the Style/NestedTernaryOperator cop and fixes 78 autocorrectable offenses.
This commit enables the Style/Next cop and fixes 152 autocorrectable offenses.
This commit enables the Style/NilComparison cop and fixes 14 autocorrectable offenses.
This commit enables the Style/NonNilCheck cop and fixes 4 autocorrectable offenses.
This commit enables the Style/Not cop and fixes 41 autocorrectable offenses.
This commit enables the Style/NumericLiteralPrefix cop and fixes 74 autocorrectable offenses.
This commit enables the Style/NumericLiterals cop and fixes 19 autocorrectable offenses.
This commit enables the Style/OneLineConditional cop and fixes 3 autocorrectable offenses.
This commit enables the Style/OrAssignment cop and fixes 9 autocorrectable offenses.
This commit enables teh Style/ParallelAssignment cop and fixes 19 autocorrectable offenses.
This commit enables the Style/ParenthesesAroundCondition cop and fixes 112 autocorrectable offenses.
This commit enables the Style/PercentLiteralDelimiters cop and fixes 121 autocorrectable offenses.
This commit enables the Style/PercentQLiterals cop and fixes 3 autcorrectable offenses.
This commit enables the Style/PerlBackrefs cop and fixes 137 autocorrectable offenses.
This commit enables the Style/Proc cop and fixes 4 autocorrectable offenses.
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
from
af6a26f to
2aa8a61
Compare
mhashizume
reviewed
Feb 27, 2024
mhashizume
reviewed
Feb 27, 2024
mhashizume
reviewed
Feb 27, 2024
mhashizume
reviewed
Feb 27, 2024
mhashizume
reviewed
Feb 27, 2024
mhashizume
reviewed
Feb 27, 2024
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
2 times, most recently
from
c16fd95 to
476f9bd
Compare
mhashizume
reviewed
Feb 27, 2024
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
2 times, most recently
from
32ba0ad to
d4772b3
Compare
mhashizume
reviewed
Feb 27, 2024
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
2 times, most recently
from
a884cb2 to
3eda4a4
Compare
This commit cleans up some changes Rubocop autocorrected such as remove extra parenthesis and breaking down ternary operators into more readable if/else statements.
AriaXLi
force-pushed
the
PUP-11993/style_cops_N-Z
branch
from
3eda4a4 to
6b5cb30
Compare
mhashizume
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.