(PUP-11993) Style/ParallelAssignment

This commit enables the Style/ParallelAssignment cop and fixes
19 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -640,23 +640,6 @@ Style/NumericPredicate:
 Style/OptionalBooleanParameter:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/ParallelAssignment:
-  Exclude:
-    - 'lib/puppet/configurer/downloader.rb'
-    - 'lib/puppet/graph/rb_tree_map.rb'
-    - 'lib/puppet/module_tool/shared_behaviors.rb'
-    - 'lib/puppet/network/client_request.rb'
-    - 'lib/puppet/parser/relationship.rb'
-    - 'lib/puppet/provider/package/ports.rb'
-    - 'lib/puppet/provider/service/smf.rb'
-    - 'lib/puppet/provider/user/aix.rb'
-    - 'lib/puppet/relationship.rb'
-    - 'lib/puppet/settings/config_file.rb'
-    - 'lib/puppet/type/file/ensure.rb'
-    - 'lib/puppet/util/suidmanager.rb'
-    - 'lib/puppet/util/windows/registry.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:

lib/puppet/configurer/downloader.rb

@@ -40,7 +40,12 @@ def evaluate
   end
 
   def initialize(name, path, source, ignore = nil, environment = nil, source_permissions = :ignore)
-    @name, @path, @source, @ignore, @environment, @source_permissions = name, path, source, ignore, environment, source_permissions
+    @name = name
+    @path = path
+    @source = source
+    @ignore = ignore
+    @environment = environment
+    @source_permissions = source_permissions
   end
 
   def file

lib/puppet/graph/rb_tree_map.rb

@@ -236,27 +236,35 @@ def colorflip
 
     def rotate_left
       r = @right
-      r_key, r_value = r.key, r.value
+      r_key = r.key
+      r_value = r.value
       b = r.left
       r.left = @left
       @left = r
       @right = r.right
       r.right = b
-      r.color, r.key, r.value = :red, @key, @value
-      @key, @value = r_key, r_value
+      r.color = :red
+      r.key = @key
+      r.value = @value
+      @key = r_key
+      @value = r_value
       self
     end
 
     def rotate_right
       l = @left
-      l_key, l_value = l.key, l.value
+      l_key = l.key
+      l_value = l.value
       b = l.right
       l.right = @right
       @right = l
       @left = l.left
       l.left = b
-      l.color, l.key, l.value = :red, @key, @value
-      @key, @value = l_key, l_value
+      l.color = :red
+      l.key = @key
+      l.value = @value
+      @key = l_key
+      @value = l_value
       self
     end
 

lib/puppet/module_tool/shared_behaviors.rb

@@ -13,7 +13,8 @@ def get_local_constraints
       @installed[mod_name] << mod
       d = @local["#{mod_name}@#{mod.version}"]
       (mod.dependencies || []).each do |hash|
-        name, conditions = hash['name'], hash['version_requirement']
+        name = hash['name']
+        conditions = hash['version_requirement']
         name = name.tr('/', '-')
         d[name] = conditions
         @conditions[name] << {

lib/puppet/network/client_request.rb

@@ -20,7 +20,9 @@ def call
     end
 
     def initialize(name, ip, authenticated)
-      @name, @ip, @authenticated = name, ip, authenticated
+      @name = name
+      @ip = ip
+      @authenticated = authenticated
     end
 
     def to_s

lib/puppet/parser/relationship.rb

@@ -26,7 +26,9 @@ def evaluate(catalog)
   end
 
   def initialize(source, target, type)
-    @source, @target, @type = source, target, type
+    @source = source
+    @target = target
+    @type = type
   end
 
   def param_name

lib/puppet/provider/package/ports.rb

@@ -62,7 +62,8 @@ def latest
             _("Could not match version info '%{info}'") % { info: info }
     end
 
-    source, newversion = $1, $2
+    source = $1
+    newversion = $2
 
     debug "Newer version in #{source}"
     newversion

lib/puppet/provider/service/smf.rb

@@ -248,7 +248,8 @@ def maybe_clear_service_then_svcadm(cur_state, subcmd, flags)
   def flush
     # We append the "_" because ensure is a Ruby keyword, and it is good to keep property
     # variable names consistent with each other.
-    enable_, ensure_ = @properties_to_sync[:enable], @properties_to_sync[:ensure]
+    enable_ = @properties_to_sync[:enable]
+    ensure_ = @properties_to_sync[:ensure]
 
     # All of the relevant properties are in sync., so we do not need to do
     # anything here.

lib/puppet/provider/user/aix.rb

@@ -72,7 +72,9 @@ def expires_to_expiry(provider, expires)
         return :absent
       end
 
-      month, day, year = match_obj[1], match_obj[2], match_obj[-1]
+      month = match_obj[1]
+      day = match_obj[2]
+      year = match_obj[-1]
       return "20#{year}-#{month}-#{day}"
     end
 

lib/puppet/relationship.rb

@@ -34,7 +34,8 @@ def event=(event)
   end
 
   def initialize(source, target, options = {})
-    @source, @target = source, target
+    @source = source
+    @target = target
 
     options = (options || {}).each_with_object({}) { |a, h| h[a[0].to_sym] = a[1]; }
     [:callback, :event].each do |option|