(CODEMGMT-659) Change to use minitar entry's full_name #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,12 +52,13 @@ def validate_files(tarfile) | |||
| file_lists = {:valid => [], :invalid => [], :symlinks => []} | |||
| Archive::Tar::Minitar.open(tarfile).each do |entry| | |||
| flag = entry.typeflag | |||
| #require 'pry'; binding.pry | |||
andersonmills
force-pushed
the
bug/master/CODEMGMT-659-minitar_call_for_full_name
branch
2 times, most recently
from
9561434 to
8e42eb9
Compare
This commit changes from using the name field of minitar's entry to full_name. name has a 100 character limit and caused incomplete file names to be extracted.
andersonmills
force-pushed
the
bug/master/CODEMGMT-659-minitar_call_for_full_name
branch
from
8e42eb9 to
e16b61a
Compare
|
👍 |
scotje
added a commit
that referenced
this pull request
Mar 10, 2016
…itar_call_for_full_name (CODEMGMT-659) Change to use minitar entry's full_name
npwalker
added a commit
to npwalker/pe_code_manager_webhook
that referenced
this pull request
Mar 11, 2016
Prior to this commit, the full path that r10k needed to untar was more than 100 characters for the classifier settings function After this commit, it should be just short of 100 characters so it works around PUP-5994 before we can get the resolution in puppetlabs/forge-ruby#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes from using the name field of minitar's entry to
full_name. name has a 100 character limit and caused incomplete file
names to be extracted.