(CODEMGMT-659) Change to use minitar entry's full_name

This commit changes from using the name field of minitar's entry to
full_name. name has a 100 character limit and caused incomplete file
names to be extracted.

Author: andersonmills

lib/puppet_forge/tar/mini.rb

@@ -52,12 +52,13 @@ def validate_files(tarfile)
         file_lists = {:valid => [], :invalid => [], :symlinks => []}
         Archive::Tar::Minitar.open(tarfile).each do |entry|
           flag = entry.typeflag
+          #require 'pry'; binding.pry
           if flag.nil? || flag =~ /[[:digit:]]/ && SYMLINK_FLAGS.include?(flag.to_i)
-            file_lists[:symlinks] << entry.name
+            file_lists[:symlinks] << entry.full_name
           elsif flag.nil? || flag =~ /[[:digit:]]/ && VALID_TAR_FLAGS.include?(flag.to_i)
-            file_lists[:valid] << entry.name
+            file_lists[:valid] << entry.full_name
           else
-            file_lists[:invalid] << entry.name 
+            file_lists[:invalid] << entry.full_name
           end
         end
         file_lists

spec/unit/forge/tar/mini_spec.rb

@@ -3,9 +3,10 @@
 describe PuppetForge::Tar::Mini do
   let(:entry_class) do
     Class.new do
-      attr_accessor :typeflag, :name
-      def initialize(name, typeflag)
+      attr_accessor :typeflag, :name, :full_name
+      def initialize(name, full_name, typeflag)
         @name = name
+        @full_name = full_name
         @typeflag = typeflag
       end
     end
@@ -15,9 +16,9 @@ def initialize(name, typeflag)
   let(:sourcedir)  { '/the/src/dir' }
   let(:destfile)   { '/the/dest/file.tar.gz' }
   let(:minitar)    { described_class.new }
-  let(:tarfile_contents) { [entry_class.new('file', '0'), \
-                            entry_class.new('symlink', '2'), \
-                            entry_class.new('invalid', 'F')] }
+  let(:tarfile_contents) { [entry_class.new('file', 'full_file', '0'), \
+                            entry_class.new('symlink', 'full_symlink', '2'), \
+                            entry_class.new('invalid', 'full_invalid', 'F')] }
 
   it "unpacks a tar file" do
     unpacks_the_entry(:file_start, 'thefile')
@@ -66,13 +67,15 @@ def initialize(name, typeflag)
 
     expect(Zlib::GzipReader).to receive(:open).with(sourcefile).and_yield(reader)
     expect(Archive::Tar::Minitar).to receive(:open).with(reader).and_return(tarfile_contents)
-    expect(Archive::Tar::Minitar).to receive(:unpack).with(reader, destdir, ['file']).and_yield(:file_start, 'thefile', nil)
-    
+    #expect(Archive::Tar::Minitar).to receive(:unpack).with(reader, destdir, ['file']).and_yield(:file_start, 'thefile', nil)
+
+    expect(Archive::Tar::Minitar).to receive(:unpack).with(reader, destdir, ['full_file']).and_yield(:file_start, 'thefile', nil)
+
     file_lists = minitar.unpack(sourcefile, destdir)
 
-    expect(file_lists[:valid]).to eq(['file'])
-    expect(file_lists[:invalid]).to eq(['invalid'])
-    expect(file_lists[:symlinks]).to eq(['symlink'])
+    expect(file_lists[:valid]).to eq(['full_file'])
+    expect(file_lists[:invalid]).to eq(['full_invalid'])
+    expect(file_lists[:symlinks]).to eq(['full_symlink'])
   end
 
   def unpacks_the_entry(type, name)