This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
FACT-2650 Fix bug when loading external facts #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 26, 2020 10:13
BogdanIrimie
reviewed
Jun 9, 2020
Comment on lines
+292
to
+295
| it 'corrects the directory path' do | ||
| allow(loader).to receive(:search_path).and_return [dir_path] | ||
|
|
||
| loader.load_all |
Filipovici-Andrei
force-pushed
the
FACT-2650
branch
from
74d967e
to
58649f7
Compare
BogdanIrimie
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running facter with external facts, in powershell, the paths given to the search_path method are not interpreted correctly and no facts are resolved.