(FACT-2650) Fix bug with wrong slashes in external fact file paths

CHANGELOG.md

@@ -193,7 +193,4 @@
 
 
 
-\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
-
-
 \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

lib/custom_facts/util/loader.rb

@@ -39,6 +39,8 @@ def load_all
 
         paths = search_path
         paths&.each do |dir|
+          # clean the search path of wrong slashes and backslashes
+          dir = dir.gsub(%r{[\/\\]+}, File::SEPARATOR)
           # dir is already an absolute path
           Dir.glob(File.join(dir, '*.rb')).each do |path|
             # exclude dirs that end with .rb

spec/custom_facts/util/loader_spec.rb

@@ -280,6 +280,24 @@ def loader_from(places)
       loader.load_all
       loader.load_all
     end
+
+    context 'when directory path has wrong slashes' do
+      before do
+        allow(Dir).to receive(:glob).with('/one/dir/*.rb').and_return %w[/one/dir/a.rb]
+      end
+
+      dir_paths = ['//one///dir', '//one///\\dir', '/one///\/\dir', '\one///\\dir']
+
+      dir_paths.each do |dir_path|
+        it 'corrects the directory path' do
+          allow(loader).to receive(:search_path).and_return [dir_path]
+
+          loader.load_all
+
+          expect(Dir).to have_received(:glob).with('/one/dir/*.rb')
+        end
+      end
+    end
   end
 
   it 'loads facts on the facter search path only once' do