Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade terraform provider azurerm to v3.89.0 #1666

Merged
merged 7 commits into from
Jan 31, 2024
Merged

upgrade terraform provider azurerm to v3.89.0 #1666

merged 7 commits into from
Jan 31, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 31, 2024 •
edited
Loading

Should address #1649

make "upstream.finalize"' failed to apply a patch. This is because there is a conflict between
the checked out version of upstream and the patch set. To resolve this conflict
run:
FROM=$LAST_KNOWN_GOOD_COMMIT make upstream.rebase
This will walk you through resolving the conflict and producing a patch set that
cleanly applies to the current upstream.

-> lies, I'll update upstream.sh so the next person doesn't get stuck here.

VenelinMartinov
VenelinMartinov commented Jan 31, 2024
View reviewed changes
provider/resources.go Outdated
Comment on lines 2654 to 2655
"azurerm_chaos_studio_target": {Tok: azureResource(azureChaosStudio, "Target")},
"azurerm_redhat_openshift_cluster": {Tok: azureResource(azureRedHatOpenShift, "Cluster")},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check I've mapped these correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashicorp/terraform-provider-azurerm#24580

provider/resources.go Outdated
@@ -3133,6 +3137,7 @@ func Provider() tfbridge.ProviderInfo {

"azurerm_orchestrated_virtual_machine_scale_set": {Tok: azureDataSource(azureCompute, "getOrchestratedVirtualMachineScaleSet")},
"azurerm_container_app": {Tok: azureDataSource(azureContainerApp, "getApp")},
"azurerm_ip_groups": {Tok: azureDataSource(azureNetwork, "getIpGroups")},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/hashicorp/terraform-provider-azurerm/pull/24540/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 3 breaking changes:

Resources

  • 🟢 "azure:appconfiguration/configurationKey:ConfigurationKey": required: "value" property is no longer Required

Types

  • 🟢 "azure:cognitive/DeploymentModel:DeploymentModel": required: "version" property is no longer Required
  • 🟢 "azure:containerapp/getAppIngress:getAppIngress": required: "ipSecurityRestrictions" property has changed to Required

New resources:

  • chaosstudio/target.Target
  • elasticsan/volumeGroup.VolumeGroup
  • netapp/accountEncryption.AccountEncryption
  • redhatopenshift/cluster.Cluster

New functions:

  • compute/getIpGroups.getIpGroups
  • datafactory/getTriggerSchedule.getTriggerSchedule
  • datafactory/getTriggerSchedules.getTriggerSchedules
  • netapp/getAccountEncryption.getAccountEncryption
  • network/getIpGroups.getIpGroups
  • nginx/getCertificate.getCertificate

Maintainer note: consult the runbook for dealing with any breaking changes.

iwahbe
iwahbe approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, then LGTM

provider/resources.go Outdated Show resolved Hide resolved
@VenelinMartinov VenelinMartinov merged commit 5f16d79 into master Jan 31, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/upgrade_3.89.0 branch January 31, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VenelinMartinov @iwahbe