-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade terraform provider azurerm to v3.89.0 #1666
Conversation
provider/resources.go
Outdated
"azurerm_chaos_studio_target": {Tok: azureResource(azureChaosStudio, "Target")}, | ||
"azurerm_redhat_openshift_cluster": {Tok: azureResource(azureRedHatOpenShift, "Cluster")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check I've mapped these correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provider/resources.go
Outdated
@@ -3133,6 +3137,7 @@ func Provider() tfbridge.ProviderInfo { | |||
|
|||
"azurerm_orchestrated_virtual_machine_scale_set": {Tok: azureDataSource(azureCompute, "getOrchestratedVirtualMachineScaleSet")}, | |||
"azurerm_container_app": {Tok: azureDataSource(azureContainerApp, "getApp")}, | |||
"azurerm_ip_groups": {Tok: azureDataSource(azureNetwork, "getIpGroups")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me.
Does the PR have any schema changes?Does the PR have any schema changes?Found 3 breaking changes: Resources
Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit, then LGTM
Should address #1649
-> lies, I'll update
upstream.sh
so the next person doesn't get stuck here.