Skip to content

treewide: Improve integration in systems #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

colluca
Copy link
Collaborator

@colluca colluca commented May 6, 2025

Several changes to streamline integration in systems, tested in Picobello.

Key features:

  • Better separation of Make fragments: vcs.mk, vsim.mk, verilator.mk, rtl.mk
  • Prefix Makefile variables with SN_ and targets with sn- to prevent name collisions when included in systems

Note: this PR is only a first in this direction, a more complete and consistent implementation will be merged shortly with a second PR.

@Lore0599
Copy link
Contributor

Lore0599 commented May 7, 2025

@colluca I think that some of the targets in the CI need to be modified. For instance here the CI should probably run sn-sw.

@colluca
Copy link
Collaborator Author

colluca commented May 7, 2025

@colluca I think that some of the targets in the CI need to be modified. For instance here the CI should probably run sn-sw.

Definitely yes, it's really still just a draft, I want to prefix the other targets and variables as well.

@colluca colluca force-pushed the soc-integration branch 7 times, most recently from e2c7235 to 306d540 Compare May 9, 2025 07:34
@colluca colluca marked this pull request as ready for review May 9, 2025 08:01
@colluca colluca force-pushed the soc-integration branch from 306d540 to 3445363 Compare May 9, 2025 08:17
Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot

@colluca colluca merged commit 8de8482 into pulp-platform:develop May 9, 2025
6 checks passed
colluca added a commit that referenced this pull request May 9, 2025
Co-authored-by: Tim Fischer <fischeti@iis.ee.ethz.ch>
@colluca colluca deleted the soc-integration branch May 9, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants