-
Notifications
You must be signed in to change notification settings - Fork 3
treewide: Bump and improve snitch_cluster
integration
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates and improves the Snitch cluster integration in preparation for multicast integration. Key changes include updating the Snitch cluster dependency to a new repository, transitioning to a JSON5 configuration, adding new targets for the Snitch cluster files, and updating the LLVM toolchain version.
Files not reviewed (4)
- Makefile: Language not supported
- cfg/snitch_cluster.json: Language not supported
- iis-env.sh: Language not supported
- target/sim/vsim/vsim.mk: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Do we want to wait for the Snitch PR#227 to be merged before pointing to the upstreamed version?
If there's any other development ongoing I would suggest merging already, so people can already work on top of this and we don't have to resolve the conflicts later. In that case, we can open a quick issue to remind us to bump the Snitch dependency. |
Yes let's merge it and open the issue |
fa19855
to
2f6f676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the Snitch cluster to the latest version on main, in preparation of multicast integration.
In summary:
Bender.yml
, and generated in same folder as other filescompile.tcl
Bender.yml
)riscv-tests
in Snitch