Skip to content

hw: Assign correct hart_base_id to snitch and SPU cluster #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

Lore0599
Copy link
Contributor

Hart IDs

This PR introduces an offset of 1 to the tile Hart IDs to account for the Cheshire tile being mapped as the first Hart.

@Lore0599 Lore0599 requested a review from fischeti May 16, 2025 13:50
@Lore0599 Lore0599 force-pushed the lleone/fix-hartId branch from db3b9ef to 635817f Compare May 16, 2025 13:54
Copy link
Collaborator

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just some nitpicks. After rebasing, it's ready to merge

@fischeti fischeti changed the title hw: Fix Hart Base ID for Cluster and FhG tiles hw: Assign correct hart_base_id to snitch and SPU cluster May 16, 2025
@Lore0599 Lore0599 force-pushed the lleone/fix-hartId branch 2 times, most recently from 65d41e3 to 4b49f97 Compare May 16, 2025 14:40
@fischeti fischeti enabled auto-merge (squash) May 16, 2025 14:42
@Lore0599 Lore0599 force-pushed the lleone/fix-hartId branch from cd89fa8 to ed2cf4c Compare May 19, 2025 11:31
@fischeti fischeti merged commit be471dd into main May 19, 2025
5 checks passed
@fischeti fischeti deleted the lleone/fix-hartId branch May 19, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants