Skip to content

Replace AXI atomic adapter with OBI atomic adapter #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

mbertuletti
Copy link
Contributor

This PR modifies the memory tile to replace the AXI to L2 memory interconnect with an AXI to OBI conversion module and an OBI to L2 memory interconnect. The OBI atomic adapter is modified to handle wide OBI transfers containing a 32b atomic transfer.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

verible-verilog-format

hw/axi_obi/src/axi_to_detailed_mem_user.sv|84|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|86|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|88|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|90|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|92|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|94|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|97|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|99|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|101|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|103|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|105|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|107|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|117|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|119|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|153|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|159|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|208|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|211|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|225|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|227|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|250|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|261|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|264|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|282|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|284|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|291|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|294|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|321|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|327|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|333|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|348|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|352|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|362|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|368|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|380|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|386|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|399|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|415|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|421|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|445|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|449|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|460|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|472|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|482|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|493|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|518|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|520|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|528|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|532|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|541|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|550|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|558|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|569|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|574|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|579|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|582|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|590|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|599|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|611|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|628|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|630|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|647|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|650|
hw/axi_obi/src/axi_to_detailed_mem_user.sv|652|
hw/axi_obi/src/axi_to_obi.sv|9|
hw/axi_obi/src/axi_to_obi.sv|11|
hw/axi_obi/src/axi_to_obi.sv|13|
hw/axi_obi/src/axi_to_obi.sv|27|
hw/axi_obi/src/axi_to_obi.sv|29|
hw/axi_obi/src/axi_to_obi.sv|31|
hw/axi_obi/src/axi_to_obi.sv|33|
hw/axi_obi/src/axi_to_obi.sv|41|
hw/axi_obi/src/axi_to_obi.sv|64|
hw/axi_obi/src/axi_to_obi.sv|73|
hw/axi_obi/src/axi_to_obi.sv|88|
hw/axi_obi/src/axi_to_obi.sv|108|
hw/axi_obi/src/axi_to_obi.sv|111|
hw/axi_obi/src/axi_to_obi.sv|114|
hw/axi_obi/src/axi_to_obi.sv|117|
hw/axi_obi/src/axi_to_obi.sv|128|
hw/axi_obi/src/axi_to_obi.sv|138|
hw/axi_obi/src/axi_to_obi.sv|154|
hw/axi_obi/src/axi_to_obi.sv|156|
hw/axi_obi/src/axi_to_obi.sv|159|
hw/axi_obi/src/axi_to_obi.sv|173|
hw/axi_obi/src/axi_to_obi.sv|179|
hw/axi_obi/src/axi_to_obi.sv|181|
hw/axi_obi/src/axi_to_obi.sv|186|
hw/axi_obi/src/axi_to_obi.sv|188|
hw/axi_obi/src/axi_to_obi.sv|193|
hw/axi_obi/src/axi_to_obi.sv|209|
hw/axi_obi/src/axi_to_obi.sv|211|
hw/axi_obi/src/axi_to_obi.sv|214|
hw/axi_obi/src/axi_to_obi.sv|228|
hw/axi_obi/src/axi_to_obi.sv|234|
hw/axi_obi/src/axi_to_obi.sv|237|
hw/axi_obi/src/axi_to_obi.sv|239|
hw/axi_obi/src/axi_to_obi.sv|243|
hw/axi_obi/src/axi_to_obi.sv|248|
hw/axi_obi/src/axi_to_obi.sv|253|
hw/axi_obi/src/axi_to_obi.sv|259|
hw/axi_obi/src/axi_to_obi.sv|268|
hw/axi_obi/src/axi_to_obi.sv|276|
hw/axi_obi/src/axi_to_obi.sv|285|
hw/axi_obi/src/axi_to_obi.sv|296|
hw/axi_obi/src/axi_to_obi.sv|298|
hw/axi_obi/src/axi_to_obi.sv|332|
hw/axi_obi/src/axi_to_obi.sv|347|
hw/axi_obi/src/obi_to_axi.sv|11|
hw/axi_obi/src/obi_to_axi.sv|13|
hw/axi_obi/src/obi_to_axi.sv|15|
hw/axi_obi/src/obi_to_axi.sv|27|
hw/axi_obi/src/obi_to_axi.sv|29|
hw/axi_obi/src/obi_to_axi.sv|32|
hw/axi_obi/src/obi_to_axi.sv|35|
hw/axi_obi/src/obi_to_axi.sv|43|
hw/axi_obi/src/obi_to_axi.sv|49|
hw/axi_obi/src/obi_to_axi.sv|60|
hw/axi_obi/src/obi_to_axi.sv|62|
hw/axi_obi/src/obi_to_axi.sv|66|
hw/axi_obi/src/obi_to_axi.sv|70|
hw/axi_obi/src/obi_to_axi.sv|72|
hw/axi_obi/src/obi_to_axi.sv|74|
hw/axi_obi/src/obi_to_axi.sv|81|
hw/axi_obi/src/obi_to_axi.sv|85|
hw/axi_obi/src/obi_to_axi.sv|88|
hw/axi_obi/src/obi_to_axi.sv|95|
hw/axi_obi/src/obi_to_axi.sv|100|
hw/axi_obi/src/obi_to_axi.sv|119|
hw/axi_obi/src/obi_to_axi.sv|126|
hw/axi_obi/src/obi_to_axi.sv|129|
hw/axi_obi/src/obi_to_axi.sv|141|
hw/axi_obi/src/obi_to_axi.sv|164|
hw/axi_obi/src/obi_to_axi.sv|170|
hw/axi_obi/src/obi_to_axi.sv|173|
hw/axi_obi/src/obi_to_axi.sv|180|
hw/axi_obi/src/obi_to_axi.sv|201|
hw/axi_obi/src/obi_to_axi.sv|218|
hw/axi_obi/src/obi_to_axi.sv|221|
hw/axi_obi/src/obi_to_axi.sv|226|
hw/axi_obi/src/obi_to_axi.sv|230|
hw/axi_obi/src/obi_to_axi.sv|233|
hw/axi_obi/src/obi_to_axi.sv|236|
hw/axi_obi/src/obi_to_axi.sv|239|
hw/axi_obi/src/obi_to_axi.sv|243|
hw/axi_obi/src/obi_to_axi.sv|247|
hw/axi_obi/src/obi_to_axi.sv|251|
hw/axi_obi/src/obi_to_axi.sv|255|
hw/axi_obi/src/obi_to_axi.sv|272|
hw/axi_obi/src/obi_to_axi.sv|278|
hw/axi_obi/src/obi_to_axi.sv|290|
hw/axi_obi/src/obi_to_axi.sv|296|
hw/axi_obi/src/obi_to_axi.sv|307|
hw/axi_obi/src/obi_to_axi.sv|310|
hw/axi_obi/src/obi_to_axi.sv|315|
hw/axi_obi/src/obi_to_axi.sv|321|
hw/axi_obi/src/obi_to_axi.sv|357|
hw/axi_obi/src/obi_to_axi.sv|370|
hw/axi_obi/src/obi_to_axi.sv|394|

@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch from c70e49b to ff16cde Compare April 29, 2025 16:01
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch from ff16cde to 67a9444 Compare April 29, 2025 16:05
@mbertuletti mbertuletti marked this pull request as draft April 29, 2025 16:14
@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch 5 times, most recently from 0b96ce8 to 81403e4 Compare May 6, 2025 15:22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add this test to the CI here?

@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch from 9cf056b to f2b3320 Compare May 9, 2025 07:46
@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch 2 times, most recently from 3c7d992 to e2f5be8 Compare May 12, 2025 12:55
@mbertuletti mbertuletti marked this pull request as ready for review May 12, 2025 16:59
@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch from e2f5be8 to 195c815 Compare May 13, 2025 05:49
Copy link
Collaborator

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot! Please rebase to master again, and fix the CI. Then it is ready to be merged

@fischeti fischeti mentioned this pull request May 13, 2025
3 tasks
@mbertuletti mbertuletti force-pushed the mbertuletti/dev_mem_tile branch from 195c815 to 8b75cda Compare May 13, 2025 08:12
@fischeti fischeti merged commit 6ff8eb8 into main May 13, 2025
5 of 6 checks passed
@fischeti fischeti deleted the mbertuletti/dev_mem_tile branch May 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants