Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream-xbar: Add payload stability assertion mask #219

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

paulsc96
Copy link
Contributor

@paulsc96 paulsc96 commented Apr 2, 2024

Fixing the reset polarity of assertions in stream_xbar and stream_omega_net (#200) uncovered numerous assertion failures in our designs using common_cells. One assertion failure we observe may result from intentional, functionally correct design.

stream_xbar and stream_omega_net are commonly used for in-cycle banked SRAM interconnects (e.g. PULP TCDM), wherein parts of a valid payload may freely change if they are not relevant to that payload.

The most common example is a shared request channel for reads and writes. The write data is always part of the payload, but on reads (i.e. when the write enable in the payload is low), it is irrelevant to the request. Thus, efficient designs may opt to hardwire write data to a write-specific datapath, which may result in write data changes while a valid read request is pending.

While functionally harmless, such changes trigger the current data stability assertions in stream_xbar and stream_omega_net which provide either strict stability assertions on all payload bits (AxiVldRdy == 1) or no stability assertions at all (AxiVldRdy == 0).

This MR adds a mask parameter AxiVldMask allowing designers to choose on which payload bits stability should be asserted. Since the default mask is '1, this change is non-breaking.

@paulsc96 paulsc96 changed the title stream-xbar: Add payload assertion stability mask stream-xbar: Add payload stability assertion mask Apr 2, 2024
Copy link
Contributor

@colluca colluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bluewww bluewww self-requested a review April 8, 2024 12:24
@bluewww
Copy link
Contributor

bluewww commented Apr 8, 2024

Sensible change lgtm.

Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@niwis niwis merged commit bbb8c10 into master Apr 9, 2024
5 checks passed
@niwis niwis deleted the paulsc/xbar-stab-mask branch April 9, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants