-
Notifications
You must be signed in to change notification settings - Fork 34
Add reuse-tool as an SPDX license header linter #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ense headers Added a wrapper python script to filter the files so we can manually skip what we don't want reuse to check. Otherwise it complains about every single file.
Reuse explicitly checks for licenses in the LICENSES directory and doesn't look for it in the LICENSE file.
…cense header checking
|
@lukamac I implemented the discussed change. Please take a look and let me know once the PR is ready for a quick review and merge. |
|
even better than the discussed change! Thanks for the effort :) |
- Call reuse via python if not install in ~/.local/bin/reuse - Ignore "TEST_*" directories - Cleanup CONTRIBUTING.md
Xeratec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one more commit to
- Call reuse via Python if not installed in
~/.local/bin/reuse - Ignore
TEST_*directories when linting and formatting - Cleanup CONTRIBUTING.md
Otherwise, I guess we are ready to merge this. Thanks for the OCD ;)
* Use [reuse-tool](https://github.com/fsfe/reuse-tool) for checking license headers Added a wrapper python script to filter the files so we can manually skip what we don't want reuse to check. Otherwise it complains about every single file. * Replace LICENSE file with LICENSES directory and Apache-2.0.txt file Reuse explicitly checks for licenses in the LICENSES directory and doesn't look for it in the LICENSE file. * Add MIT license for the scripts/run_clang_format.py * Add missing license headers * Configure and add CC BY-NC 4.0 license * Update Readme * Call reuse via python if not in PATH * Ignore "TEST_*" directories * Update CONTRIBUTING.md --------- Co-authored-by: Philip Wiese <wiesep@iis.ee.ethz.ch>
* Use [reuse-tool](https://github.com/fsfe/reuse-tool) for checking license headers Added a wrapper python script to filter the files so we can manually skip what we don't want reuse to check. Otherwise it complains about every single file. * Replace LICENSE file with LICENSES directory and Apache-2.0.txt file Reuse explicitly checks for licenses in the LICENSES directory and doesn't look for it in the LICENSE file. * Add MIT license for the scripts/run_clang_format.py * Add missing license headers * Configure and add CC BY-NC 4.0 license * Update Readme * Call reuse via python if not in PATH * Ignore "TEST_*" directories * Update CONTRIBUTING.md --------- Co-authored-by: Philip Wiese <wiesep@iis.ee.ethz.ch>
* Use [reuse-tool](https://github.com/fsfe/reuse-tool) for checking license headers Added a wrapper python script to filter the files so we can manually skip what we don't want reuse to check. Otherwise it complains about every single file. * Replace LICENSE file with LICENSES directory and Apache-2.0.txt file Reuse explicitly checks for licenses in the LICENSES directory and doesn't look for it in the LICENSE file. * Add MIT license for the scripts/run_clang_format.py * Add missing license headers * Configure and add CC BY-NC 4.0 license * Update Readme * Call reuse via python if not in PATH * Ignore "TEST_*" directories * Update CONTRIBUTING.md --------- Co-authored-by: Philip Wiese <wiesep@iis.ee.ethz.ch>
* Use [reuse-tool](https://github.com/fsfe/reuse-tool) for checking license headers Added a wrapper python script to filter the files so we can manually skip what we don't want reuse to check. Otherwise it complains about every single file. * Replace LICENSE file with LICENSES directory and Apache-2.0.txt file Reuse explicitly checks for licenses in the LICENSES directory and doesn't look for it in the LICENSE file. * Add MIT license for the scripts/run_clang_format.py * Add missing license headers * Configure and add CC BY-NC 4.0 license * Update Readme * Call reuse via python if not in PATH * Ignore "TEST_*" directories * Update CONTRIBUTING.md --------- Co-authored-by: Philip Wiese <wiesep@iis.ee.ethz.ch>
This release includes improvements to the tiling and DMA code generation, new networks and operators, improved CI workflows, migration to PyTest, and support for PyPi package releases. Note: Since the release tag references the Docker container tagged with the release tag (ghcr.io/pulp-platform/deeploy:v0.2.1), the CI will initially fail. The Deeploy Docker image must be built after the release PR is merged and the CI restarted. ### List of Pull Requests - PyPi Package Deployment + Remove Banshee Dept [#154](#154) - PyTest Migration [#144](#144) - Update submodule `pulp-nn-mixed` [#145](#145) - Improve Profiling [#138](#138) - FP32 ReduceMean operator improvement [#137](#137) - Support for RMSNorm (Pow and Sqrt operators) [#136](#136) - Demo TinyViT compatibility with tiled Siracusa [#124](#124) - TinyViT on non-tiled Siracusa [#117](#117) - Support Fully Asynchronous DMAs [#114](#114) - Disallow shape inference [#128](#128) - Remove memory-aware node bindings [#123](#123) - Fix missing const's layout transformation and refactor NCHWtoNHWC passes [#122](#122) - Fix aliasing [#125](#125) - Support for 1D Autoencoder [#98](#98) - Refactor Logging for Improved Debugging [#115](#115) - Add reuse-tool as an SPDX license header linter [#113](#113) - Bug fixes, API Cleanup and Reduce Compiler Warning on PULP [#112](#112) - Fix PULP GEMM `batch` serialization [#109](#109) - Split CI Workflows by Platform and Task, Improve Formatting and Linting Reliability [#108](#108) - Refactor tiling code generation [#105](#105) - Change order of typeMatching entries [#68](#68) - Node Mangling to avoid duplication [#93](#93) - Prepare Post v0.2.0 Release [#104](#104) - Use Docker digests instead of arch-specific tags [#106](#106) - Fix `Unsqueeze` Op. when using ONNX opset 13 or higher (from attribute to input) [#119](#119) - Fix bias hoisting in generic GEMM with no bias [#126](#126)
This is an evolution of the #111 PR with the change to reuse-tool for linting.
I used an adapted version of the
license_fix.pyscript from that PR to fix the license headers but didn't include it in this PR.Added
reuse_skip_wrapper.pyto manually skip filesChanged
PR Merge Checklist
develcommit and pointing todevel.CHANGELOG.mdfile has been updated.