-
Notifications
You must be signed in to change notification settings - Fork 34
Use Docker digests instead of arch-specific tags #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaces per-architecture tags (e.g., *-amd64, *-arm64) with direct digest references when creating the multi-arch Docker manifest. This reduces tag clutter in the registry.
124b064 to
a84f6e5
Compare
lukamac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge approved.
This is not part of this PR, but just for my curiosity, why are we using the ubuntu-22.04-arm runner and not the ubuntu-24.04-arm one?
No specific reason, it is just the one I used from the beginning, and I did not test the latest one. It is expected to reach the end of life Linux after April 2027, which should be fine for now. I suggest we update if we face an issue, but it is worth even the 10 min to test this now. |
* Update action versions and fix missing id * Avoid platform-specific image tags by using digests in Docker manifest * Replaces per-architecture tags (e.g., *-amd64, *-arm64) with direct digest references when creating the multi-arch Docker manifest. This reduces tag clutter in the registry. * Update Changelog
* Update action versions and fix missing id * Avoid platform-specific image tags by using digests in Docker manifest * Replaces per-architecture tags (e.g., *-amd64, *-arm64) with direct digest references when creating the multi-arch Docker manifest. This reduces tag clutter in the registry. * Update Changelog
This release includes improvements to the tiling and DMA code generation, new networks and operators, improved CI workflows, migration to PyTest, and support for PyPi package releases. Note: Since the release tag references the Docker container tagged with the release tag (ghcr.io/pulp-platform/deeploy:v0.2.1), the CI will initially fail. The Deeploy Docker image must be built after the release PR is merged and the CI restarted. ### List of Pull Requests - PyPi Package Deployment + Remove Banshee Dept [#154](#154) - PyTest Migration [#144](#144) - Update submodule `pulp-nn-mixed` [#145](#145) - Improve Profiling [#138](#138) - FP32 ReduceMean operator improvement [#137](#137) - Support for RMSNorm (Pow and Sqrt operators) [#136](#136) - Demo TinyViT compatibility with tiled Siracusa [#124](#124) - TinyViT on non-tiled Siracusa [#117](#117) - Support Fully Asynchronous DMAs [#114](#114) - Disallow shape inference [#128](#128) - Remove memory-aware node bindings [#123](#123) - Fix missing const's layout transformation and refactor NCHWtoNHWC passes [#122](#122) - Fix aliasing [#125](#125) - Support for 1D Autoencoder [#98](#98) - Refactor Logging for Improved Debugging [#115](#115) - Add reuse-tool as an SPDX license header linter [#113](#113) - Bug fixes, API Cleanup and Reduce Compiler Warning on PULP [#112](#112) - Fix PULP GEMM `batch` serialization [#109](#109) - Split CI Workflows by Platform and Task, Improve Formatting and Linting Reliability [#108](#108) - Refactor tiling code generation [#105](#105) - Change order of typeMatching entries [#68](#68) - Node Mangling to avoid duplication [#93](#93) - Prepare Post v0.2.0 Release [#104](#104) - Use Docker digests instead of arch-specific tags [#106](#106) - Fix `Unsqueeze` Op. when using ONNX opset 13 or higher (from attribute to input) [#119](#119) - Fix bias hoisting in generic GEMM with no bias [#126](#126)
This PR improves the Docker image publishing workflow by switching from per-architecture tags to digest-based references when assembling multi-architecture manifests. This simplifies the tagging strategy and avoids excessive tag proliferation in the container registry. It also includes minor CI fixes and version bumps.
New Toolchain Image Workflow: https://github.com/Xeratec/Deeploy/actions/runs/16173929110
New Deeploy Image Workflow: https://github.com/Xeratec/Deeploy/actions/runs/16177376174
Toolchain Container: https://github.com/Xeratec/Deeploy/pkgs/container/deeploy-toolchain
Deeploy Container: https://github.com/Xeratec/Deeploy/pkgs/container/deeploy
Added
amd64,arm64) after build, which is used to construct the multi-arch Docker manifest. This prevents registry clutter caused by unnecessary per-architecture Docker tags.Changed
*-amd64,*-arm64) with direct digest references inNoelware/docker-manifest-action.Fixed
idin theBuild Cache for Dockerstep, used in theInject build-cachestep.PR Merge Checklist
develcommit and points todevel.CHANGELOG.mdfile has been updated.