-
Notifications
You must be signed in to change notification settings - Fork 90
Revoke token #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Revoke token #124
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5cf3245
Add revoke token
kleewho 3789a21
Update pubnub.yml
kleewho abbc06b
Fix the error message for missing token
kleewho 5eea09d
Merge branch 'master' into revoke_token
parfeon d257cf9
Print out pretty report to console for acceptance
kleewho 25d455b
PubNub SDK v4.8.0 release.
7b739f6
PubNub SDK v4.8.0 release.
fd21d9d
docs: clear duplicated entries in changelog
parfeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
module Pubnub | ||
# Holds revoke token functionality | ||
class RevokeToken < SingleEvent | ||
include Concurrent::Async | ||
include Pubnub::Validator::RevokeToken | ||
|
||
def initialize(options, app) | ||
@event = :revoke_token | ||
super | ||
@token = @token.split(' ') | ||
.map{ |part| CGI.escape(part) } | ||
.join("%20") | ||
end | ||
|
||
private | ||
|
||
def current_operation | ||
Pubnub::Constants::OPERATION_GRANT_TOKEN | ||
end | ||
|
||
def valid_envelope(parsed_response, req_res_objects) | ||
Pubnub::Envelope.new( | ||
event: @event, | ||
event_options: @given_options, | ||
timetoken: nil, | ||
status: { | ||
code: req_res_objects[:response].code, | ||
client_request: req_res_objects[:request], | ||
server_response: req_res_objects[:response], | ||
category: Pubnub::Constants::STATUS_ACK, | ||
error: false, | ||
auto_retried: false, | ||
|
||
current_timetoken: nil, | ||
last_timetoken: nil, | ||
subscribed_channels: nil, | ||
subscribed_channel_groups: nil, | ||
|
||
data: nil, | ||
|
||
config: get_config | ||
|
||
}, | ||
result: { | ||
code: req_res_objects[:response].code, | ||
operation: current_operation, | ||
client_request: req_res_objects[:request], | ||
server_response: req_res_objects[:response], | ||
|
||
data: parsed_response['data'] | ||
} | ||
) | ||
end | ||
|
||
|
||
def path | ||
'/' + [ | ||
'v3', | ||
'pam', | ||
@subscribe_key, | ||
'grant', | ||
@token | ||
].join('/') | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Toplevel Pubnub module. | ||
module Pubnub | ||
# Validator module that holds all validators modules | ||
module Validator | ||
# Validator for Grant event | ||
module RevokeToken | ||
include CommonValidator | ||
|
||
def validate! | ||
validate_keys! | ||
validate_token! | ||
end | ||
|
||
private | ||
|
||
def validate_keys! | ||
raise( | ||
ArgumentError.new(object: self, message: ':subscribe_key is required for revoke token event.'), | ||
':subscribe_key is required for grant token event.' | ||
) if @subscribe_key.nil? || @subscribe_key.empty? | ||
end | ||
|
||
def validate_token! | ||
raise( | ||
ArgumentError.new(object: self, message: ':token is required for revoke token event.'), | ||
':token is required for revoke token event.' | ||
) if @token.nil? || @token.empty? | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.