Skip to content

Revoke token #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 16, 2021
Merged

Revoke token #124

merged 8 commits into from
Dec 16, 2021

Conversation

kleewho
Copy link
Contributor

@kleewho kleewho commented Nov 15, 2021 •
edited
Loading

feat: Add revoke token feature

parfeon
parfeon requested changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least error fix required.

@parfeon parfeon self-requested a review December 16, 2021 13:16
parfeon
parfeon previously approved these changes Dec 16, 2021
View reviewed changes
@parfeon parfeon self-requested a review December 16, 2021 17:03
parfeon
parfeon previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@parfeon
Copy link
Contributor

parfeon commented Dec 16, 2021

@client-engineering-bot release

1 similar comment
@kleewho
Copy link
Contributor Author

kleewho commented Dec 16, 2021

@client-engineering-bot release

Client Engineering Bot and others added 2 commits December 16, 2021 17:04
PubNub SDK v4.8.0 release.
7b739f6
@parfeon
docs: clear duplicated entries in changelog
fd21d9d 
Remove duplicated entries from `.pubnub.yml` and `CHANGELOG.md` files.
@parfeon parfeon self-requested a review December 16, 2021 17:10
parfeon
parfeon approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good

@kleewho kleewho merged commit b382302 into master Dec 16, 2021
@kleewho kleewho deleted the revoke_token branch December 16, 2021 17:42
@github-actions
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parfeon parfeon parfeon approved these changes

@bartk bartk Awaiting requested review from bartk

@CraigLn CraigLn Awaiting requested review from CraigLn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kleewho @parfeon