Added Module parameter and an [IO.Path]::Combine() to Build-PSBuildUpdatableHelp#55
Merged
devblackops merged 2 commits intopsake:mainfrom Sep 16, 2022
Merged
Added Module parameter and an [IO.Path]::Combine() to Build-PSBuildUpdatableHelp#55devblackops merged 2 commits intopsake:mainfrom
devblackops merged 2 commits intopsake:mainfrom
Conversation
The Module parameter removes the dependency on the $ModuleName variable in the parent scope while maintaining the existing behavior of inheriting its value. The LandingPagePath key in $cabParams now uses the [IO.Path]::Combine([string[]]) method rather than manual string concatenation
Member
|
Thanks @IMJLA! |
Merged
HeyItsGilbert
added a commit
that referenced
this pull request
Oct 6, 2024
### Changed - Bump Pester to latest 5.6.1 ### Fixed - [**#52**](#52) Pester object wasn't being passed back after running tests, causing the Pester task to never fail (via [@webtroter](https://github.com/webtroter)) - [**#55**](#55) Add `-Module` parameter to `Build-PSBuildUpdatableHelp` (via [@IMJLA](https://github.com/IMJLA)) - [**#60**](#60) Fix Windows PowerShell compatibility in `Initialize-PSBuild` (via [@joshooaj](https://github.com/joshooaj)) - [**#62**](#62) Fix code coverage output fle format not working (via [@OpsM0nkey](https://github.com/OpsM0nkey))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Module parameter removes the dependency on the $ModuleName variable in the parent scope while maintaining the existing behavior of inheriting its value.
The LandingPagePath key in $cabParams now uses the [IO.Path]::Combine([string[]]) method rather than manual string concatenation
Related Issue
#54
Motivation and Context
This will make it easier to use Build-PSBuildUpdatableHelp in custom psake files or other contexts
How Has This Been Tested?
All 195 existing Pester tests passed
Also tested in a vacuum as demonstrated by the example in the Issue
Screenshots (if appropriate):
Types of changes
Checklist: