Changes $configuration.Run.PassThru to $True#52
Merged
devblackops merged 1 commit intopsake:mainfrom Aug 12, 2021
Merged
Conversation
Before Pester V5, the -PassThru parameter was used. We could either use the -PassThru parameter, or set the run configuration in the Configuration Parameter.
devblackops
approved these changes
Aug 12, 2021
Merged
HeyItsGilbert
added a commit
that referenced
this pull request
Oct 6, 2024
### Changed - Bump Pester to latest 5.6.1 ### Fixed - [**#52**](#52) Pester object wasn't being passed back after running tests, causing the Pester task to never fail (via [@webtroter](https://github.com/webtroter)) - [**#55**](#55) Add `-Module` parameter to `Build-PSBuildUpdatableHelp` (via [@IMJLA](https://github.com/IMJLA)) - [**#60**](#60) Fix Windows PowerShell compatibility in `Initialize-PSBuild` (via [@joshooaj](https://github.com/joshooaj)) - [**#62**](#62) Fix code coverage output fle format not working (via [@OpsM0nkey](https://github.com/OpsM0nkey))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Pester V5, the -PassThru parameter was used.
We could either use the -PassThru parameter, or set the run configuration in the Configuration Parameter.
Description
Currently, the Pester task never really fails, because Invoke-Pester doesn't PassThru
Related Issue
#51
Motivation and Context
Before the migration to PesterV5, the PassThru parameter was used, and the replacement in V5 was set to false in the PSBuild Task
How Has This Been Tested?
Changing it in my machine makes the task fail as it should.
Types of changes
Checklist: