Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check builder's payload block number #13224

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Check builder's payload block number #13224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c2fd4
Check builder's payload parent hash
potuz Nov 24, 2023
ff2ed94
use block number instead
potuz Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions beacon-chain/rpc/prysm/v1alpha1/validator/proposer_bellatrix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ func setExecutionData(ctx context.Context, blk interfaces.SignedBeaconBlock, loc
log.WithError(err).Warn("Proposer: failed to get builder payload value") // Default to local if can't get builder value.
return setLocalExecution(blk, localPayload)
}
// Check that the builder has built the right blocknumber
if builderPayload.BlockNumber() != localPayload.BlockNumber() {
log.Warn("Proposer: builder's payload has the wrong block number, using local block.") // Default to local if can't get builder value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Can we also log the numbers?

return setLocalExecution(blk, localPayload)
}

withdrawalsMatched, err := matchingWithdrawalsRoot(localPayload, builderPayload)
if err != nil {
Expand Down
Loading