Check builder's payload block number #13224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
changed the title
| @@ -71,6 +71,11 @@ func setExecutionData(ctx context.Context, blk interfaces.SignedBeaconBlock, loc | |||
| log.WithError(err).Warn("Proposer: failed to get builder payload value") // Default to local if can't get builder value. | |||
| return setLocalExecution(blk, localPayload) | |||
| } | |||
| // Check that the builder has built the right blocknumber | |||
| if builderPayload.BlockNumber() != localPayload.BlockNumber() { | |||
| log.Warn("Proposer: builder's payload has the wrong block number, using local block.") // Default to local if can't get builder value. | |||
There was a problem hiding this comment.
Makes sense to me. Can we also log the numbers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before checking for withdrawals roots that involves hashing, perform a quick check that the builder actually returned a block for the right block number. Previous version of this PR would actually check the parent hash, but fixing tests is more involved.