Skip to content

Conversation

SpicyLemon
Copy link

@SpicyLemon SpicyLemon commented Apr 4, 2025

Description

This PR makes a couple changes needed for the flat-fees stuff:


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

SpicyLemon and others added 11 commits February 12, 2025 16:52
* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <al@essio.dev>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Zachary Becker <zrbecker@gmail.com>
…616)

* Improve performance of GetAllBalances and GetAccountsBalances.

* Add changelog entry.
* Merge commit from fork

* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add changelog entry.

* Put nothing back at the top of the changelog.

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
@SpicyLemon SpicyLemon marked this pull request as ready for review July 8, 2025 19:58
@SpicyLemon SpicyLemon enabled auto-merge (squash) July 8, 2025 20:03
@SpicyLemon SpicyLemon changed the title Remove fee handler and make DefaultGasLimit a var. Remove fee handler and fix post-handler error handling. Jul 8, 2025
@SpicyLemon SpicyLemon marked this pull request as draft July 8, 2025 23:41
auto-merge was automatically disabled July 8, 2025 23:41

Pull request was converted to draft

@SpicyLemon
Copy link
Author

SpicyLemon commented Jul 15, 2025

I ran the following make targets locally and they all completed successfully:

  • make test
  • make test-sim-nondeterminism
  • make test-sim-import-export
  • make test-sim-after-import
  • make test-sim-multi-seed-short

The tests in the orm dir fail to compile because the SDK ripped out a bunch of stuff (but not all of it). But we don't use any of the orm stuff, and it's in its own library/package so that's fine.

@SpicyLemon SpicyLemon marked this pull request as ready for review July 15, 2025 21:04
@SpicyLemon SpicyLemon merged commit 79d1c73 into release-pio/v0.50.x Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants