Skip to content

Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. #615

merged 4 commits into from
Mar 26, 2025

Conversation

SpicyLemon
Copy link

Description

This PR brings our release-pio/v0.50.x branch up-to-date with the SDK's v0.50.13 release. It also marks v0.50.13-pio-1 in the changelog.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

alpe and others added 2 commits March 25, 2025 14:28
@alpe @SpicyLemon
Merge commit from fork
5107874 
* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
@SpicyLemon
Add changelog entry.
eeb45a1
@SpicyLemon SpicyLemon changed the title Prov/dwedul/bring in 0.50.13 Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. Mar 26, 2025
@SpicyLemon
Copy link
Author

I ran the following make targets locally and they all completed successfully:

  • make test*
  • make test-sim-nondeterminism
  • make test-sim-import-export
  • make test-sim-after-import
  • make test-sim-multi-seed-short

* The cosmossdk.io/orm don't run because it can't find some imports that are in itself. I'm not sure why it suddenty can't find that stuff, though. If I do a go mod tidy, it indicates that it's trying to use cosmossdk.io/orm v0.50.13, which I don't think is right. I'm guessing the orm package is supposed to have its own tag, and that latest is getting confused by the SDK version tag. So it's looking to use the wrong thing.

Running unit tests for module cosmossdk.io/orm
model/ormtable/iterator.go:11:2: cannot find module providing package cosmossdk.io/orm/model/ormlist: import lookup disabled by -mod=readonly
internal/codegen/query.go:17:2: cannot find module providing package cosmossdk.io/orm/internal/fieldnames: import lookup disabled by -mod=readonly
internal/testkv/debug.go:10:2: cannot find module providing package cosmossdk.io/orm/internal/stablejson: import lookup disabled by -mod=readonly

All of the other stuff compiles and runs successfully.

@SpicyLemon SpicyLemon merged commit ef74bc3 into release-pio/v0.50.x Mar 26, 2025
SpicyLemon added a commit that referenced this pull request Apr 4, 2025
@SpicyLemon @alpe
Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615)
b3aa1ef 
* Merge commit from fork

* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add changelog entry.

* Put nothing back at the top of the changelog.

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
SpicyLemon added a commit that referenced this pull request Jul 15, 2025
@SpicyLemon @dependabot
@julienrbrt @alessio @zrbecker @alpe
Remove fee handler and fix post-handler error handling. (#618)
79d1c73 
* Remove the fee handler customization since the SDK added a post handler that does pretty much the same thing.

* Make DefaultGasLimit a variable instead of constant.

* Fix the post handler response code thing.

* Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614)

* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <al@essio.dev>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#616)

* Improve performance of GetAllBalances and GetAccountsBalances.

* Add changelog entry.

* Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615)

* Merge commit from fork

* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add changelog entry.

* Put nothing back at the top of the changelog.

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add a bunch of logging.

* Revert "Add a bunch of logging."

This reverts commit 3baf4d3.

* Make the DefaultGasLimit a constant again (back to how the SDK has it).

* Add changelog entry.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Zachary Becker <zrbecker@gmail.com>
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshock dcshock dcshock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpicyLemon @dcshock @alpe