Add minzoom exception for British Columbia region label #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521
It turns out that British Columbia did not have a minzoom / maxzoom exception in the places.csv file.
Since there is no exception, the region label appears only from zoom 8:
https://maps.protomaps.com/#flavorName=light&lang=en&map=10.46/54.8549/-125.0621
You see that the wikidata id of British Columbia is Q1973.
On the other hand, Alberta appears nicely from lower zooms:
https://maps.protomaps.com/#flavorName=light&lang=en&map=4.74/51.62/-123.62
Alberta has wikidata id Q1951
This pull requests adds a line for Q1973 (British Columbia) which has the same config as Q1951 (Alberta).