Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove unused f expression from jscode gen. (#5573)" #5932

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

dankurka
Copy link
Contributor

The removed variable here is actually used breaking downstream bazel
builds.

…5573)"

The removed variable here is actually used breaking downstream bazel
builds.
@acozzette
Copy link
Member

LGTM

@acozzette acozzette merged commit e2461b5 into protocolbuffers:3.7.x Mar 21, 2019
dankurka referenced this pull request Mar 21, 2019
Varadic assignment in javascript where the right hand expression is an
object yields a single set assignment with the right most lefthand variable,
while leaving the other left side expressions undefined.

For example:
var a,b = {}

will only initialize a to undefined. But will set b to the {} value.

--

For this code since f is never used, it is a safe operation to remove
it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants