Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unused f expression from jscode gen. (#5573)
Varadic assignment in javascript where the right hand expression is an object yields a single set assignment with the right most lefthand variable, while leaving the other left side expressions undefined. For example: var a,b = {} will only initialize a to undefined. But will set b to the {} value. -- For this code since f is never used, it is a safe operation to remove it.
- Loading branch information
94a1819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that variable is actually used and this broke protobuf/js externally. Reverting this.
94a1819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
94a1819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.