Update dependencies, drop unsupported ruby versions, create rubocop todo#22
Merged
yaacov merged 3 commits intoprometheus:masterfrom Feb 21, 2023
Merged
Update dependencies, drop unsupported ruby versions, create rubocop todo#22yaacov merged 3 commits intoprometheus:masterfrom
yaacov merged 3 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
Member
|
hi, thank you |
yaacov
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I wanted to only update faraday, but found out that almost everything is outdated.
Changes:
Tests and rubocop are green.
TODO:
If you don't mind and everything is ok with these changes, I'll also open a couple of follow ups to deal with rubocop todos and enable new cops.
What do you think about moving from travis to github workflows? UPD: is travis even working?