Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid metric name panic reading powercap dir #1800

Closed
wants to merge 8 commits into from
Closed

Fix invalid metric name panic reading powercap dir #1800

wants to merge 8 commits into from

Commits on Jul 27, 2020

  1. Fix invalid metric name panic reading powercap dir 

    Issue:
When the rz.Name contains invalid metric character ("-") like this:
# cat /sys/class/powercap/intel-rapl:0/name
package-15

Node exporter will panic

```
panic: "node_rapl_package-15_joules_total" is not a valid metric name
```

Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d0e7535 View commit details
    Browse the repository at this point in the history

  2. Fixed imports 

    Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d3cc495 View commit details
    Browse the repository at this point in the history

  3. Replace strings.Replace w/ strutil.SanitizeLabelName 

    Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d99586b View commit details
    Browse the repository at this point in the history

  4. Put rz.Name as value of name label 

    Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    3d51b99 View commit details
    Browse the repository at this point in the history

  5. Update rapl_linux.go 

    Formatting

Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    4c1ae90 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Update e2e-output.txt 

    Removed old rapl metrics

Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a679e54 View commit details
    Browse the repository at this point in the history

  2. Update e2e-output.txt 

    Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    7a400fd View commit details
    Browse the repository at this point in the history

  3. Update e2e-output.txt 

    Signed-off-by: chinhnc <chicknsoupuds@gmail.com>
    @chicknsoup
    chicknsoup committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    48256b0 View commit details
    Browse the repository at this point in the history