Fix invalid metric name panic reading powercap dir

[chicknsoup]

Issue:
When the rz.Name contains invalid metric character ("-") like this:
# cat /sys/class/powercap/intel-rapl:0/name
package-15

Node exporter will panic

panic: "node_rapl_package-15_joules_total" is not a valid metric name

Signed-off-by: chinhnc chicknsoupuds@gmail.com

[chicknsoup]

How to fix the incompatible module? @roidelapluie

go: found github.com/prometheus/prometheus/util/strutil in github.com/prometheus/prometheus v2.5.0+incompatible

[roidelapluie]

The fix here is maybe putting that name in a label value and fixing the metric name

[chicknsoup]

The fix here is maybe putting that name in a label value and fixing the metric name

Already put the name in a label-value pair. But, not sure how to fix the failed tests.

[discordianfish]

This would be a breaking change and 'name' probably isn't the best label name. But yeah I feel like this should probably be a label, not change to the metrics name. @SuperQ @pgier wdyt?

[brian-brazil]

I happened across this independently, looking at the docs (https://www.kernel.org/doc/html/latest/power/powercap/powercap.html) "power zone" is the name so some variant of that as the label name could work.

[SuperQ]

There's also an issue in the procfs library that needs to be fix: prometheus/procfs#320

[uniemimu]

#320 looks pretty good to me. I did wonder though, what hardware could have that many packages. None the less, I think it looks like a proper fix. Br, Ukri

…

________________________________ From: Ben Kochie <notifications@github.com> Sent: Thursday, August 20, 2020 2:28 PM To: prometheus/node_exporter <node_exporter@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [prometheus/node_exporter] Fix invalid metric name panic reading powercap dir (#1800) There's also an issue in the procfs library that needs to be fix: prometheus/procfs#320<prometheus/procfs#320> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#1800 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAADPRV7XOTJJH2IRQNSG53SBUCFDANCNFSM4PILG7KQ>. --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

[SuperQ]

Closing in favor of using the procfs fix.