feat: add timeout option for pagerduty notifier #4354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to manager timeout for the context that is passed to pagerduty calls. Group level context is set to wider intervals such as 5mins, whereas we would like to set lower level threasholds for pagerduty integrations to have limit on retries and intermediate blockers in the network. Signed-off-by: emreya <e.yazici1990@gmail.com>
Signed-off-by: emreya <e.yazici1990@gmail.com>
eyazici90
force-pushed
the
local/timeoutt
branch
from
74e830d to
97ab57a
Compare
To see if timeout option is obeyed. Signed-off-by: emreya <e.yazici1990@gmail.com>
This was referenced Apr 18, 2025
To improve readability of the test. Signed-off-by: emreya <e.yazici1990@gmail.com>
Contributor
Author
|
@grobinson-grafana Could u help me with the review? 🙏 |
Contributor
Author
|
Could u help me with review @SuperQ ? |
SuperQ
approved these changes
Oct 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is to manage timeout for the context that is passed to pagerduty calls. Group level context is set to wider intervals on the dispatcher such as 5mins default, whereas we would like to set lower level thresholds for pagerduty integrations to have limit on retries and intermediate blockers in the network.
Relates to #4348
Case
In our setup with HA usage of AM, we use proxy for egress comm from alertmanagers to PD(pagerduty) that sits in between. Our proxy may lead to block such calls taking way longer than expected leading to no retries and hanging connections at alertmanager side as the parent context is set at dispatcher that is group interval.
We should be able to set smaller duration timeout for outgoing calls to pagerduty, consequently having more controls for robust communication.