feat: add timeout option for slack notifier #4355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to manager timeout for the context that is passed to slack calls. Group level context is set to wider intervals such as 5mins, whereas we would like to set lower level threasholds for slack integrations to have limit on retries and intermediate blockers in the network. Signed-off-by: emreya <e.yazici1990@gmail.com>
Signed-off-by: emreya <e.yazici1990@gmail.com>
To see if timeout option is obeyed. Signed-off-by: emreya <e.yazici1990@gmail.com>
| } | ||
| } | ||
|
|
||
| func TestSlackTimeout(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Do we want to add a test case to show if parent context is canceled, then child context also gets canceled?
Contributor
Author
There was a problem hiding this comment.
Not sure about the value that would bring. do we aim to check if context is propagated to downstream funcs? I haven't seen any test like that for other places in AM. Could u point me to an example? Perhaps I missed it.
Contributor
rajagopalanand
left a comment
rajagopalanand
left a comment
There was a problem hiding this comment.
Had one question regarding a test case
Contributor
Author
|
@grobinson-grafana Could u help me with the review? 🙏 |
pehlicd
approved these changes
Jul 29, 2025
Contributor
Author
|
Could u help me with review @SuperQ ? |
SuperQ
reviewed
Oct 19, 2025
Signed-off-by: Ben Kochie <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is to manage timeout for the context that is passed to slack calls. Group level context is set to wider intervals on the dispatcher such as 5mins default, whereas we would like to set lower level thresholds for slack integrations to have limit on retries and intermediate blockers in the network.
Relates to #4348
Case
In our setup with HA usage of AM, we use proxy for egress comm from alertmanagers to slack(mattermost) that sits in between. Our proxy may lead to block such calls taking way longer than expected leading to no retries and hanging connections at alertmanager side as the parent context is set at dispatcher that is group interval.
We should be able to set smaller duration timeout for outgoing calls to slack, consequently having more controls for robust communication.