-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in acceptance tests #3592
Merged
gotjosh
merged 2 commits into
prometheus:main
from
grobinson-grafana:grobinson/fix-panic-acceptance-tests
Feb 13, 2024
Merged
Fix panic in acceptance tests #3592
gotjosh
merged 2 commits into
prometheus:main
from
grobinson-grafana:grobinson/fix-panic-acceptance-tests
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
} | ||
|
||
err := t.amc.Start() | ||
if err != nil { | ||
t.T.Fatal(err) | ||
t.T.Log(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The panic occurred because the test called Fatal
which calls runtime.Goexit
. This caused the stack to unwind and the defer function to be called. When this happened, am.cmd
contained a nil Process
field.
grobinson-grafana
force-pushed
the
grobinson/fix-panic-acceptance-tests
branch
from
November 2, 2023 20:41
040187a
to
34bb89f
Compare
This commit attempts to address a panic that occurs in acceptance tests if a server in the cluster fails to start. Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/fix-panic-acceptance-tests
branch
from
November 2, 2023 21:07
34bb89f
to
2e7e1e4
Compare
gotjosh
reviewed
Feb 13, 2024
Signed-off-by: George Robinson <george.robinson@grafana.com>
gotjosh
approved these changes
Feb 13, 2024
grobinson-grafana
added a commit
to grafana/mimir
that referenced
this pull request
Feb 14, 2024
This commit updates Alertmanager from f69a508 to d352d16. It has the following changes: - prometheus/alertmanager#3565 - prometheus/alertmanager#3718 - prometheus/alertmanager#3707 - prometheus/alertmanager#3719 - prometheus/alertmanager#3592 - prometheus/alertmanager#3572 - prometheus/alertmanager#3722
4 tasks
gotjosh
pushed a commit
to grafana/mimir
that referenced
this pull request
Feb 15, 2024
* Alertmanager: Update Alertmanager to commit d352d16 This commit updates Alertmanager from f69a508 to d352d16. It has the following changes: - prometheus/alertmanager#3565 - prometheus/alertmanager#3718 - prometheus/alertmanager#3707 - prometheus/alertmanager#3719 - prometheus/alertmanager#3592 - prometheus/alertmanager#3572 - prometheus/alertmanager#3722
th0th
pushed a commit
to th0th/alertmanager
that referenced
this pull request
Mar 23, 2024
* Fix panic in acceptance tests This commit attempts to address a panic that occurs in acceptance tests if a server in the cluster fails to start. Signed-off-by: George Robinson <george.robinson@grafana.com> * Remove started and check am.cmd.Process != nil Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Gokhan Sari <gokhan@sari.me>
SuperQ
added a commit
that referenced
this pull request
Oct 16, 2024
* [CHANGE] Deprecate and remove api/v1/ #2970 * [CHANGE] Remove unused feature flags #3676 * [CHANGE] Newlines in smtp password file are now ignored #3681 * [CHANGE] Change compat metrics to counters #3686 * [CHANGE] Do not register compat metrics in amtool #3713 * [CHANGE] Remove metrics from compat package #3714 * [CHANGE] Mark muted alerts #3793 * [FEATURE] Add metric for inhibit rules #3681 * [FEATURE] Support UTF-8 label matchers #3453, #3507, #3523, #3483, #3567, #3568, #3569, #3571, #3595, #3604, #3619, #3658, #3659, #3662, #3668, 3572 * [FEATURE] Add counter to track alerts dropped outside of time_intervals #3565 * [FEATURE] Add date and tz functions to templates #3812 * [FEATURE] Add limits for silences #3852 * [FEATURE] Add time helpers for templates #3863 * [FEATURE] Add auto GOMAXPROCS #3837 * [FEATURE] Add auto GOMEMLIMIT #3895 * [FEATURE] Add Jira receiver integration #3590 * [ENHANCEMENT] Add the receiver name to notification metrics #3045 * [ENHANCEMENT] Add the route ID to uuid #3372 * [ENHANCEMENT] Add duration to the notify success message #3559 * [ENHANCEMENT] Implement webhook_url_file for discord and msteams #3555 * [ENHANCEMENT] Add debug logs for muted alerts #3558 * [ENHANCEMENT] API: Allow the Silences API to use their own 400 response #3610 * [ENHANCEMENT] Add summary to msteams notification #3616 * [ENHANCEMENT] Add context reasons to notifications failed counter #3631 * [ENHANCEMENT] Add optional native histogram support to latency metrics #3737 * [ENHANCEMENT] Enable setting ThreadId for Telegram notifications #3638 * [ENHANCEMENT] Allow webex roomID from template #3801 * [BUGFIX] Add missing integrations to notify metrics #3480 * [BUGFIX] Add missing ttl in pushhover #3474 * [BUGFIX] Fix scheme required for webhook url in amtool #3409 * [BUGFIX] Remove duplicate integration from metrics #3516 * [BUGFIX] Reflect Discord's max length message limits #3597 * [BUGFIX] Fix nil error in warn logs about incompatible matchers #3683 * [BUGFIX] Fix a small number of inconsistencies in compat package logging #3718 * [BUGFIX] Fix log line in featurecontrol #3719 * [BUGFIX] Fix panic in acceptance tests #3592 * [BUGFIX] Fix flaky test TestClusterJoinAndReconnect/TestTLSConnection #3722 * [BUGFIX] Fix crash on errors when url_file is used #3800 * [BUGFIX] Fix race condition in dispatch.go #3826 * [BUGFIX] Fix race conditions in the memory alerts store #3648 * [BUGFIX] Hide config.SecretURL when the URL is incorrect. #3887 * [BUGFIX] Fix invalid silence causes incomplete updates #3898 * [BUGFIX] Fix leaking of Silences matcherCache entries #3930 * [BUGFIX] Close SMTP submission correctly to handle errors #4006 Signed-off-by: SuperQ <superq@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to address a panic that occurs in acceptance tests if a server in the cluster fails to start:
It's not the perfect fix, but I'd like to see if it helps and how much. If it does work then we can look at improving on it further.