-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize default metrics #190
Conversation
Rename metric from `process_virtual_bytes` to `process_virtual_memory_bytes`
Rename metric from `process_private_bytes` to `process_private_memory_bytes`
Rename metric from `process_working_set` to `process_working_set_bytes`
Add metric `process_open_handles`
Rename metric from `dotnet_totalmemory` to `dotnet_total_memory_bytes`
943d09e
to
641ba01
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 87.34% 87.91% +0.57%
==========================================
Files 48 48
Lines 1691 1746 +55
Branches 228 234 +6
==========================================
+ Hits 1477 1535 +58
+ Misses 164 161 -3
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@sanych-sun Hi, any ideas on how we can collect these metrics? process_resident_memory_bytes
process_open_fds
process_max_fds |
I'm not sure about |
"fds" - is it count of open file descriptors? If so, not sure if it's possible without pinvoke. We might want to report Process.HandleCount, but this count includes any kind of handle, not just open files. |
I found these metrics in Go and Java client |
I will come back to this task soon |
eaab8ef
to
8bc322b
Compare
8bc322b
to
0b8a3e1
Compare
Rename metrics:
Add metrics:
Should be compatible with https://grafana.com/grafana/dashboards/10427