Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize default metrics #189

Closed
phnx47 opened this issue Feb 20, 2022 · 2 comments · Fixed by #190
Closed

Normalize default metrics #189

phnx47 opened this issue Feb 20, 2022 · 2 comments · Fixed by #190
Assignees
@phnx47
Labels
enhancement
Milestone
5.0

Comments

@phnx47
Copy link
Member

phnx47 commented Feb 20, 2022

@phnx47 phnx47 added this to the 5.0 milestone Feb 20, 2022
@phnx47 phnx47 self-assigned this Feb 20, 2022
@phnx47 phnx47 changed the title Standardize default metrics Normalize default metrics Feb 20, 2022
@phnx47 phnx47 linked a pull request Feb 20, 2022 that will close this issue
Normalize default metrics #190
Merged
@sanych-sun
Copy link
Member

sanych-sun commented Feb 22, 2022 •
edited
Loading

can we add some configuration or settings to allow "legacy metric names" as this is a breaking change that will require dashboards rework on client side?

@phnx47
Copy link
Member Author

phnx47 commented Feb 23, 2022

@sanych-sun Good point, we have some options. I will add my ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phnx47 phnx47

Labels
enhancement
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Normalize default metrics prom-client-net/prom-client
2 participants
@phnx47 @sanych-sun